Description: Crash at undo: deleting table in footnote with track changes record ON and undo Steps to Reproduce: 1. Open attachment 120527 [details] 2. Edit -> Track Changes -> Record (ON). Show (OFF) 3. Place the cursor inside the table in footnote 4. Press delete table 5. Select the remaining frame & press delete 6. CTRL+Z (2x) Actual Results: Crash Expected Results: No crash Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: a9ad36ae46ff76c0d59b0d170314fdd3a9ee5d35 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded
Reproduced in: Version: 7.3.7.2 / LibreOffice Community Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 56767830b81fa21382b87cf43d78b1c73ca5dbd8 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded with "lcl_IsCalcUpperAllowed(SwFrame const&)" signature: https://crashreport.libreoffice.org/stats/crash_details/fdc912c9-a2b4-4700-9cbb-44cd44e6dc60 Not reproduced in: Version: 7.2.0.4 / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Bibisected with linux-64-7.3 repo to first bad build [df9a79f154879de8998598ee11fd17fc4ada6456] which points to core commit e07ea7a6f5f7059663e99daa97cbda5e63b141dd which is a cherrypick of: commit 0c6221e1545e7b96d9df23cdc24302c28ae935b8 author László Németh Fri Mar 25 15:27:21 2022 +0100 committer László Németh Mon Mar 28 09:41:34 2022 +0200 tdf#148227 sw: fix Undo of tracked row deletion in Hide Changes mode Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132123 László, can you please have a look?
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/14c0f2cd140da66d38a8282332f2cb734bb74e39 tdf#159026 sw: fix Undo crash with tracked floating table deletion It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Telesto & Stéphane: thanks for your report and bibisect! The crash was solved my fix, but it seems, in Hide Changes mode, deletion of a single table row completely removes the view of a floating table. I'm not sure, that this problem was already reported.
(In reply to László Németh from comment #3) > @Telesto & Stéphane: thanks for your report and bibisect! The crash was > solved my fix, but it seems, in Hide Changes mode, deletion of a single > table row completely removes the view of a floating table. I'm not sure, > that this problem was already reported. Thanks for the quick fix, László! > Hide Changes mode, deletion of a single table row completely removes the view of > a floating table. I confirm. No report about his as far I'm aware... ------ Side-note: What is your view on the stance, quote: "Tables are not meant to work in footnotes in general (e.g. if you go to the footnote, then Table -> Insert Table is gray for a reason)..." bug 158740 comment 5 by Miklos Vajna. Is this still valid? Or are we moving to a point where it's allowed to add table into a footnote?
László Németh committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/de7e0bc32d3629063f13250ae3b7c9f934fba046 tdf#159026 sw: fix Undo crash with tracked floating table deletion It will be available in 24.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/1b79e993fefbf102466f7a0e394e71478a643896 tdf#159026 sw: fix Undo crash with tracked floating table deletion It will be available in 7.6.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks László! Fix verified in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a2ccc25ccb2e94f5990d6d413541dbcdd3a72338 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded (In reply to László Németh from comment #3) > it seems, in Hide Changes mode, deletion of a single > table row completely removes the view of a floating table. I'm not sure, > that this problem was already reported. Good catch, I've reported it in bug 159107.