Created attachment 191847 [details] sample DOCX When deleting a row in a table in a footnote, with track changes on (but not visible), the whole table disappears and can't be brought back with Ctrl + Z. Steps: 1. open attachment (has Record: On; Show: Off) 2. click inside footnote table 3. delete row: whole table disappears (and is greyed out in Navigator) 4. Ctrl + Z: no table nor row come back Reproduced in recent trunk build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e83c7ec2f4d801365235bf56d7cc8cf31ef4a00e CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Bibisected with linux-64-7.6 repository to first bad build [fcf57c8efc126fb5a1cabefd2a3e8d33c57d5860] which points to core commit ce3308a926f036b87515b8cd97d2b197063dc77a, but using ImportFloatingTableAsSplitFly = true, bibisected to first bad build [4678abe6162fa40671a976ec7fb04e581240a852] which points to: commit d477fa8ac1b0d3ee81427217bbb5950278ab16db author Miklos Vajna Fri Mar 17 14:00:17 2023 +0100 committer Miklos Vajna Fri Mar 17 14:10:34 2023 +0000 sw floattable: unconditionally map <w:tblpPr> to SwFormatFlySplit Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149044 Miklos, can you please have a look?
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/af15f8b7f346898677f1eee6521a6be1ff63eb56 tdf#159107 sw floattable: prefer inline table in footnote with change tracking It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
^ Laszlo: the above fixes the immediate regression, but if you have time, then fixing the root cause at a layout level may be interesting, it's probably some table-in-not-split-fly or redline-table problem. This just tweaks the DOCX import to not trigger the layout bug.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/d19f051dd4244bdfb58458d4287305b59c2915c6 tdf#159107 sw floattable: prefer inline table in footnote with change tracking It will be available in 24.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/9589438d53f32ba7b59512d56a6dbd1d28de70a6 tdf#159107 sw floattable: prefer inline table in footnote with change tracking It will be available in 7.6.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fix verified in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ef9e1116d1100af50d7b74dcee5155c81b7b50fb CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thanks Miklos! :)