Bug 159145 - allow changing width of comment column by making the right border draggable
Summary: allow changing width of comment column by making the right border draggable
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Samuel Mehrbrodt (allotropia)
URL:
Whiteboard: target:24.8.0 inReleaseNotes:24.8
Keywords:
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
 
Reported: 2024-01-12 11:23 UTC by steve
Modified: 2024-09-08 23:25 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
proposed UX to change comment column width (569.68 KB, image/png)
2024-01-12 11:23 UTC, steve
Details

Note You need to log in before you can comment on or make changes to this bug.
Description steve 2024-01-12 11:23:19 UTC
Description:
https://bugs.documentfoundation.org/show_bug.cgi?id=73953 introduced a new default width and also the possibility to change the width of that column.

Those changes were much needed and are a huge improvement. The UX of changing column width is not idea.

Steps to Reproduce:
1. write some text
2. add a comment
3. try changing the column width

Actual Results:
In order to change comment column width users have to show `View > Rulers > Rulers` to then drag the right border of the comment field in the ruler UI.

Expected Results:
It would be much more intuitive and user friendly, if comment column width could just be changed in writer UI by allowing to drag the right border of the comment column.

Nothing against allowing to drag commment element in the ruler UI, but not all users have the ruler UI active and allowing to drag that column border is so trivial, intuitive and obvious I don#t see why that should not be added.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ba8f4bff6015013013df652efbfaf4d9ae10c881
CPU threads: 8; OS: macOS 13.6.3; UI render: Skia/Raster; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded
Comment 1 steve 2024-01-12 11:23:32 UTC
Created attachment 191885 [details]
proposed UX to change comment column width
Comment 2 Rafael Lima 2024-01-12 11:35:58 UTC Comment hidden (obsolete)
Comment 3 Rafael Lima 2024-01-12 11:44:11 UTC
(In reply to steve from comment #0)

Okay, considering this portion here:

> It would be much more intuitive and user friendly, if comment column width
> could just be changed in writer UI by allowing to drag the right border of
> the comment column.

Yes, it would be useful to be able to drag from the right border of the entire comment column. This could be helpful for users who disable the ruler.

I'll switch it back to unconfirmed.
Comment 4 m_a_riosv 2024-01-13 02:33:41 UTC
+1
Comment 5 Heiko Tietze 2024-01-15 15:23:32 UTC
I would expect a splitter left of the comments pane. But right is also good. Samuel, how big is the hurdle to get this interaction into the document canvas?
Comment 6 steve 2024-01-15 16:06:03 UTC
Heiko, how would users interact if the splitter was on the left side of the comment column? The size is changed on the right side as the left border remains static as it is next to the document canvas. Or am I misunderstanding what you wrote?
Comment 7 Heiko Tietze 2024-01-15 16:27:21 UTC
(In reply to steve from comment #6)
> Heiko, how would users interact if the splitter was on the left side...
How about moving the document canvas left-wards by extending the comment section. Could be done together with scrolling so you just enlarge or shrink the margin comments pane with the splitter. My point is that typically a splitter is between panes and not at the edge. 

Whether a splitter or not, I'm afraid of huge effort for little benefit.
Comment 8 vena.cava@virgin.net 2024-01-18 12:23:02 UTC Comment hidden (off-topic)
Comment 9 Commit Notification 2024-01-22 11:20:01 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b9368eab798a766b5a24658c783a6ee73dbf2caa

tdf#159145 Allow changing width of comment column on right border

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 steve 2024-01-23 11:44:45 UTC
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d71c21890c908225945f0fc3566255ed150f660
CPU threads: 8; OS: macOS 13.6.3; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_DE.UTF-8); UI: en-US
Calc: threaded

verified + followup https://bugs.documentfoundation.org/show_bug.cgi?id=159146