Bug 159327 - Wrong (stock) icons picked with gtk3
Summary: Wrong (stock) icons picked with gtk3
Status: RESOLVED NOTOURBUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-22 15:44 UTC by Heiko Tietze
Modified: 2024-01-25 14:31 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (5.09 KB, image/png)
2024-01-22 15:44 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2024-01-22 15:44:04 UTC
Created attachment 192101 [details]
Screenshot

Starting with SAL_USE_VCLPLUGIN=gtk3 ends up in invisible TabButtons icons. System theme is Breeze Dark, kf5 works flawless. Switching from Karasa Jaga to Colibre Dark or Breeze Dark has no effect on the tabbar even after restarting the application.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 084c64982ef6187292fd73e6deaa4448e0b6f3de
CPU threads: 32; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: de-DE (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Heiko Tietze 2024-01-22 15:56:45 UTC
The tabbar is Glade based svtools/uiconfig/ui/tabbuttons.ui and uses stock icons, eg. go-first. Same issue for the print dialog, which is also using stock icons. So this is likely an issue by the gtk3 theme. See for example https://www.reddit.com/r/openSUSE/comments/hwr963/broken_theming_in_gtk3_apps_when_using_breezedark/
Comment 2 Buovjaga 2024-01-22 16:04:45 UTC
I confirm it, but per our discussion, as the icons come from the operating system, it is not our bug.
Comment 3 Heiko Tietze 2024-01-22 16:11:50 UTC
Thinking about to replace stock icons is a bad idea. We may be able to fit one OS but wouldn't comply with all.
Comment 4 Heiko Tietze 2024-01-25 10:41:28 UTC
I wonder if DecorationView::DrawSymbol() with SymbolType::FIRST would be a solution/cause for the issue. See also https://gerrit.libreoffice.org/c/core/+/162460.

Caolan, what do you think?
Comment 5 Caolán McNamara 2024-01-25 12:44:22 UTC
That patch is for a different bug I think, it refers to bug #159329 for AutoFilter arrows instead of this TabButton icon issue
Comment 6 Heiko Tietze 2024-01-25 14:31:58 UTC
(In reply to Caolán McNamara from comment #5)
> That patch is for a different bug...
Yes, it just brought me to the idea that stock icons not necessarily have to be wrong.