Bug 159346 - FILEOPEN PPTX Extra borders above first and below last table rows
Summary: FILEOPEN PPTX Extra borders above first and below last table rows
Status: RESOLVED NOTOURBUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium normal
Assignee: Tibor Nagy
URL:
Whiteboard:
Keywords: implementationError
Depends on:
Blocks: PPTX-Tables
  Show dependency treegraph
 
Reported: 2024-01-23 21:31 UTC by Gabor Kelemen (allotropia)
Modified: 2024-03-04 20:50 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
The example file in 24.0 after the fix to bug 156718 (88.99 KB, image/png)
2024-01-23 21:31 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of the example file in PP 2010 and Impress master (64.32 KB, image/png)
2024-01-31 15:28 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-01-23 21:31:10 UTC
Created attachment 192130 [details]
The example file in 24.0 after the fix to bug 156718

This is a followup to bug 156718

In attachment 188911 [details] there are extra border lines above the first row of the table and below the last.

1. Open attachment 188911 [details] 
-> border above the Old New row and below the Tau -> TRAIN

Version: 24.2.1.0.0+ (X86_64) / LibreOffice Community
Build ID: d29208007d2f0d3de489d813900afa9667869d76
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: hu-HU
Calc: threaded

This started in 6.4 when table style settings started to be imported:

https://git.libreoffice.org/core/+/2c3f7d4ee0a0b2bf6efc41670645bd361f1b76ef

author	Gülşah Köse <gulsah.kose@collabora.com>	Fri Dec 27 21:06:08 2019 +0300
committer	Andras Timar <andras.timar@collabora.com>	Tue Jan 07 14:49:50 2020 +0100

tdf#107604 Handle predefined table styles.

then all rows got above/below borders.
That improved to only the top/bottom rows having the extra borders in 7.4 with:

https://git.libreoffice.org/core/+/3faf005a367cbd28077403bf93810bbaf4805851

author	Gülşah Köse <gulsah.kose@collabora.com>	Tue Feb 01 16:03:14 2022 +0300
committer	Gülşah Köse <gulsah.kose@collabora.com>	Wed Mar 02 11:57:25 2022 +0100

tdf#135843 Implement inside horizontal vertical borders.

After the fix to bug 156718 I see an extra bottom border of the first row too, so that's a minor regression.
Comment 1 Gerald Pfeifer 2024-01-24 13:10:21 UTC
Confirming this with today's daily build of

  Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
  Build ID: d0dcd87788910e3c9f67a2b68534019c05b77bad
  CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US
Comment 2 Gabor Kelemen (allotropia) 2024-01-31 15:28:24 UTC
Created attachment 192288 [details]
Screenshot of the example file in PP 2010 and Impress master

Checking in a more recent version, looks like there are actually lines rendered in PP as well on the top and bottom of the table, checked in 2010/16/21: it looks like this in all of them.

In online too:

https://view.officeapps.live.com/op/view.aspx?src=https%3A%2F%2Fbugs.documentfoundation.org%2Fattachment.cgi%3Fid%3D188911

Which is not consistent with the attachment 188912 [details] screnshot, that has no borders in PP.

Which version of MSO is this, 365? I have no idea why are there no borders.
Comment 3 Gerald Pfeifer 2024-02-20 14:46:09 UTC
(In reply to Gabor Kelemen (allotropia) from comment #2)
> Checking in a more recent version, looks like there are actually lines
> rendered in PP as well on the top and bottom of the table, checked in
> 2010/16/21: it looks like this in all of them.
> 
> In online too:
:
> Which is not consistent with the attachment 188912 [details] screnshot, that
> has no borders in PP.
> 
> Which version of MSO is this, 365? I have no idea why are there no borders.

Yes, that was O365 at the time I filed the original bug report, 2023-08-10.

And in my comment #1 above I double checked Impress, alas not PowerPoint,
which seems to have changed behavior since then. I just gave 
attachment #188911 [details] from bug #156718 another try in O365 and now
it has those three lines per your screenshot in comment #2 above. 

Given that, shall we close this report as WORKSFORME?
Comment 4 Gerald Pfeifer 2024-03-04 20:50:22 UTC
Given how Microsoft/PowerPoint have changed behavior, what appeared
to be an Impress issue actually is not - just for a period the online
version of PowerPoint behaved differently.

So, if anything, their bug, not ours.