Bug 159706 - Incorrect page boundary position when page gaps are collapsed
Summary: Incorrect page boundary position when page gaps are collapsed
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:24.8.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2024-02-13 11:25 UTC by lvm
Modified: 2024-03-05 19:59 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
testcase (54.66 KB, application/vnd.oasis.opendocument.text)
2024-02-13 11:25 UTC, lvm
Details
screenshot with page gaps expanded (56.41 KB, image/png)
2024-02-13 11:26 UTC, lvm
Details
screenshot with page gaps collapsed (80.16 KB, image/png)
2024-02-13 11:27 UTC, lvm
Details
screenshot (466.57 KB, image/png)
2024-02-13 15:06 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lvm 2024-02-13 11:25:52 UTC
Created attachment 192540 [details]
testcase

Prerequisites: normal view (paginated), page gap is visible, default paragraph style allows splitting paragraph between pages

enter more than one multi-paragraph page of text in such a way that a paragraph is split between two pages
doubleclick on the page gap to collapse it

page gap is displayed not in its correct position but at the next paragraph boundary  - check the attached screenshots with page boundary expanded and collapsed

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 17763; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

screenshots and test file are attached
Comment 1 lvm 2024-02-13 11:26:14 UTC
Created attachment 192541 [details]
screenshot with page gaps expanded
Comment 2 lvm 2024-02-13 11:27:09 UTC
Created attachment 192542 [details]
screenshot with page gaps collapsed
Comment 3 BogdanB 2024-02-13 15:06:23 UTC
Created attachment 192544 [details]
screenshot

In the left image is 7.4, on the right is 24.2.
Do you consider 7.4 is better than 24.2, or what is the exact bug?

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 10981fb2fa26474f432e85165b1babbca6d74e16
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 4 lvm 2024-02-13 17:15:00 UTC
> In the left image is 7.4, on the right is 24.2.
> Do you consider 7.4 is better than 24.2, or what is the exact bug?
As far as this bug is concerned they are exactly the same - thay have it. The bug is that when the page gap is collapsed page break changes its position: when the gap is expanded it is after the line "quis magna at dapibus. Proin nec nulla quis odio commodo rutrum. Morbi fermentum euismod risus" two lines before the end of the paragraph but when it is collapsed it is after "pellentesque." at the very end of the paragraph.
Comment 5 raal 2024-02-13 19:10:36 UTC
Confirm with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f289fe3dca487c45417f7b40d51a4830f3369fb1
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

and Version: 5.3.0.0.alpha1+

Works in Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Comment 6 raal 2024-02-13 19:23:05 UTC
This seems to have begun at the below commit in bibisect repository/OS bibisect-linux-64-5.2.
Adding Cc: to Miklos Vajna ; Could you possibly take a look at this one?
Thanks
 7a88da46b3a944639a614d2e80d3048074d7e73f is the first bad commit
commit 7a88da46b3a944639a614d2e80d3048074d7e73f
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri Dec 8 09:57:46 2017 +0100

    source 6d8da2b2deb4be2182ca1852cec7eb38a4c654eb

21445: tdf#96943 sw Hide Whitespace: don't create pages for widow / orphan ... | https://gerrit.libreoffice.org/c/core/+/21445
Comment 7 Commit Notification 2024-03-05 11:57:30 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c5ac0ffae47dd2da74aaddd26e100aeb3b814c0b

tdf#159706 sw hide whitespace: fix lost follow on enabling this

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 BogdanB 2024-03-05 19:59:28 UTC
Now it's ok. Thanks, Miklos.

Verified with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a082762fb3f41237df6385ab27f7a75d6ff92690
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded