Bug 159718 - Inappropriate right-alignment of Navigator contents with RTL locale and LTR UI
Summary: Inappropriate right-alignment of Navigator contents with RTL locale and LTR UI
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
Depends on:
Blocks: Navigator RTL-UI
  Show dependency treegraph
 
Reported: 2024-02-14 12:31 UTC by Eyal Rozenberg
Modified: 2024-09-07 08:46 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Navigator with right-aligned contents (131.25 KB, image/png)
2024-02-14 12:33 UTC, Eyal Rozenberg
Details
Two navigators, now left aligned (136.18 KB, image/png)
2024-02-14 12:34 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2024-02-14 12:31:12 UTC
When everything about my document is LTR, and my LO UI is LTR, I expect the tree of navigable items in the navigator to be laid out LTR - and aligned to the left of its containing white rectangle.

Now, when I open a new document, and it's RTL by default (RTL default page style text direction) - I see the Navigator contents aligned to the right. It's LTR in direction, but right-aligned.

This remains the case even if I:

* Change the default page style's text direction to LTR
* Change the default paragraph style's text direction to explicit LTR
* Change the default paragraph style's alignment to Left

Build info:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ffccbf4762a9ae810bcdd21c41fccdd436e7bfc9
CPU threads: 4; OS: Linux 6.6; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US
Comment 1 Eyal Rozenberg 2024-02-14 12:33:26 UTC
... but if I toggle View | Navigator, and detach the navigator - both the sidebar navigator and the separate-window navigator become left-aligned.

Will attach screenshots.
Comment 2 Eyal Rozenberg 2024-02-14 12:33:58 UTC
Created attachment 192560 [details]
Navigator with right-aligned contents
Comment 3 Eyal Rozenberg 2024-02-14 12:34:19 UTC
Created attachment 192561 [details]
Two navigators, now left aligned
Comment 4 V Stuart Foote 2024-02-14 15:11:17 UTC
But you already are able to undock and then dock the SB to left edge of appframe (with SB content panel reversal) to make RTL more appealing.
Comment 5 V Stuart Foote 2024-02-14 15:21:30 UTC
The LTR <==> RTL will follow the Tools -> Options -> Languages and Locales -> General panel setting for Formats 'Locale setting:'

SB will respond to that alignment for you when working LTR if you check the 'Ignore system input language'

Of course the .UI packing of the top toolbar of the Navigator is semi-fixed and does not follow the locale for LTR <==> RTL, suppose it could but seems a waste of dev effort as IMHO no usability issue requiring it.
Comment 6 Eyal Rozenberg 2024-02-23 14:34:54 UTC
(In reply to V Stuart Foote from comment #4)
> But you already are able to undock and then dock the SB to left edge of
> appframe (with SB content panel reversal) to make RTL more appealing.

I don't understand why docking or undocking anywhere is relevant to this issue.

(In reply to V Stuart Foote from comment #5)
> The LTR <==> RTL will follow the Tools -> Options -> Languages and Locales
> -> General panel setting for Formats 'Locale setting:'

Ok, but - this bug report is about left-alignment vs right-alignment.


> Of course the .UI packing of the top toolbar of the Navigator is semi-fixed
> and does not follow the locale for LTR <==> RTL, suppose it could but seems
> a waste of dev effort as IMHO no usability issue requiring it.

I don't understand that sentence.

Anyway, when my UI is LTR, the navigator items should be left-aligned, not right-aligned, regardless of the locale. And this should certainly not change when I play with having a floating navigator.
Comment 7 Buovjaga 2024-09-04 13:18:44 UTC
Do you have reliable steps to reproduce? I could reproduce once, but subsequent attempts failed.

I modified default page style, Page tab, Text direction: Right-to-left.
Comment 8 Eyal Rozenberg 2024-09-04 21:08:30 UTC
(In reply to Buovjaga from comment #7)
> Do you have reliable steps to reproduce?

The initial right-alignment:

1. Set the locale to an RTL one (e.g. he-IL)
2. Create a new Writer document

that's it.

> I modified default page style, Page tab, Text direction: Right-to-left.

If you follow my steps-to-reproduce - those three changes never have an effect. For me, at least.
Comment 9 Buovjaga 2024-09-05 06:55:38 UTC
Thanks, I launched with LC_ALL=fa_IR.utf8 as I happened to have it generated.

Bibisected the change with linux-64-7.4 to 84ad4fe061ebfbbcdc0ffeec329e117250627157
tdf#148432 in LTR UI override the navigator treeview direction for RTL doc

So an earlier request from you.
Comment 10 Eyal Rozenberg 2024-09-05 08:20:20 UTC
(In reply to Buovjaga from comment #9)
> So an earlier request from you.

I didn't quite manage to parse that sentence, can you rephrase?
Comment 11 Buovjaga 2024-09-05 08:41:39 UTC
(In reply to Eyal Rozenberg from comment #10)
> (In reply to Buovjaga from comment #9)
> > So an earlier request from you.
> 
> I didn't quite manage to parse that sentence, can you rephrase?

Bug 148432 was filed by you.
Comment 12 Eyal Rozenberg 2024-09-07 08:46:09 UTC
(In reply to Buovjaga from comment #11)
> Bug 148432 was filed by you.

So, I guess maybe the fix exposed how the alignment does not take its value from the correct setting...