Bug 159774 - Broken line connectors
Summary: Broken line connectors
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: PPTX-line-connector-import
  Show dependency treegraph
 
Reported: 2024-02-19 12:06 UTC by Mukul Gupta
Modified: 2024-02-20 01:09 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Broken line connector (33.16 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2024-02-19 12:06 UTC, Mukul Gupta
Details
Comparsion LibreOffice 24.8 master vs MSO (54.87 KB, image/png)
2024-02-19 12:29 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mukul Gupta 2024-02-19 12:06:01 UTC
Description:
The line connection between two shape is not in correct position

Steps to Reproduce:
1.Open file in libreoffice impress
2.Lines connecting two shape is not in correct position

Actual Results:
Lines connecting two shape is not in correct position

Expected Results:
It should be in correct position


Reproducible: Always


User Profile Reset: No

Additional Info:
Nothing
Comment 1 Mukul Gupta 2024-02-19 12:06:44 UTC
Created attachment 192631 [details]
Broken line connector
Comment 2 Xisco Faulí 2024-02-19 12:29:52 UTC
Created attachment 192632 [details]
Comparsion LibreOffice 24.8 master vs MSO
Comment 3 Xisco Faulí 2024-02-19 12:35:19 UTC
Regression introduced by:

author	Tibor Nagy <nagy.tibor2@nisz.hu>	2022-03-10 08:42:12 +0100
committer	László Németh <nemeth@numbertext.org>	2022-03-29 16:12:45 +0200
commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8 (patch)
tree c7e02c1e50525e42d7b15d000398631be3c7c697
parent bc601af632861896bdfaa14c96daf1a7ffdfcf71 (diff)
tdf#89449 PPTX import: fix line connectors

Bisected with: bibisect-linux64-7.4
Comment 4 Regina Henschel 2024-02-19 14:50:18 UTC
(In reply to Xisco Faulí from comment #3)
> Regression introduced by:
> 
> author	Tibor Nagy <nagy.tibor2@nisz.hu>	2022-03-10 08:42:12 +0100
> committer	László Németh <nemeth@numbertext.org>	2022-03-29 16:12:45 +0200
> commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8 (patch)
> tree c7e02c1e50525e42d7b15d000398631be3c7c697
> parent bc601af632861896bdfaa14c96daf1a7ffdfcf71 (diff)
> tdf#89449 PPTX import: fix line connectors
> 
> Bisected with: bibisect-linux64-7.4

I don't think, that it is a regression from that commit. Before the work of Tibor the connectors were not imported as connectors but as simple shapes. When you drag the cylinder to the right, the "connector" tip will not follow. That means, that it is not really a connector.

The problem is, that a can has five gluepoints in OOXML. But these gluepoints are not imported because they are missing in https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/customshapes/oox-drawingml-cs-presets. Thus the default gluepoints are used. (The OOXML preset name of the shape is "can".)

I don't know how this file has been generated.
Comment 5 Regina Henschel 2024-02-19 15:04:03 UTC
It seems the file had initially no gluepoints at all and Tibor has added them manually for some shape types in https://gerrit.libreoffice.org/c/core/+/130281.