Bug 159812 - undo does not restore table when track changes on
Summary: undo does not restore table when track changes on
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Undo-Redo Track-Changes-Table
  Show dependency treegraph
 
Reported: 2024-02-21 04:57 UTC by Stéphane Guillou (stragu)
Modified: 2024-02-21 05:00 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2024-02-21 04:57:44 UTC
Split from bug 159196, this is a regression in 7.6.

Steps:
1. Open attachment 191950 [details]
2. Click in cell with text "Task 1.1"
3. Delete column
4. Undo

Result: hangs; no table.
No issue if changes are not tracked.

Using linux-64-7.6 repo, bibisected to first bad build [ef40a621e99ce3c3abd2ad9b67915eec060f3ef8] which points to e91faddabdf5d586c0044a3e125bdea6c2e21532 which is a cherrypick of:

commit fe43f5971dfd2a121634eea9e39c7ad0cf3f962a
author	László Németh 	Thu Jul 27 15:40:52 2023 +0200
committer	László Németh 	Thu Jul 27 23:45:53 2023 +0200
tdf#156475 sw tracked table column: delete empty cell
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154994

Before the commit, the whole table with its contents would be restored after undoing.

Things have changed in step 3 since then: whole table disappears at step 3. But this is something that was also seen in early versions (e.g. OOo 3.3), so it is tracked separately in bug 159196.

László, can you please have a look?

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ef9e1116d1100af50d7b74dcee5155c81b7b50fb
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2024-02-21 05:00:45 UTC
I just noticed bug 159195, seems very similar but it was bibisected to a different commit.