Created attachment 192729 [details] Popup in PP This is Enhancement request to add command to clean up unused master slides. Inpsired by large slow to open presentations as seen in bug 158773. With a large numbers of these, like dosens, it is cumbersone to to manually. In a proprietary office suite, there is a popup on fileopen asking if we want to reduce the number of master slides by removing unused ones. Not sure how it works, what is the threshold. So, it would be good for the beginning to have a command in LO to do it.
We already have the option "Delete unused master slides" in Tools > Minimize Presentation > Slides. Do you suggest making it available outside of that dialog?
Thanks, I did not notice the command before. But we still may have something in this ticket. It may be useful to ask warn about large number of unused master slides in that yellow notification bar. IDK now what is large or unusual, but that is secondary.
OK, let's see what UX/Design think then. This would likely require a new UNO command.
(In reply to Timur from comment #2) > It may be useful to warn about large number of unused master slides... I wonder in what situation this may happen. The shipped templates have a reasonable number of master slides. Perhaps if you play with the Master Slides sidebar deck or the Change Slide Master... function. Attachment 188496 [details] from bug 156400 has ~400 master slides. Is it a constructed example? Fixing bug 158773 sounds more reasonable to me than alerting the user at some random number.
Created attachment 193111 [details] PPTX with large number of master slides (In reply to Heiko Tietze from comment #4) > I wonder in what situation this may happen. We had a case, explosion of number that was fixed in bug 157740. Whoever used saving to PPTX might have gotten many master slides that sow down Impress. Since original from bug 155512 does not give warning in MSO, I attach modified one that does. > Attachment 188496 [details] from bug 156400 has ~400 master slides. Is it a constructed example? It does not give warning in MSO, cannot say why. Maybe it is about duplicated master slides. > Fixing bug 158773 sounds more reasonable to me than alerting the user at > some random number. I think those are different issues. MSO loads prez very fast but still warns for unusual number of master slides, that may plague the usage.
We discussed the topic in the design meeting. The warning could offer to delete unused master slides and should happen on load; covers also issues with import from other applications. Ideally we realize it per infobar to not block the workflow (user may just click away the confirmation box), the label could be "You have an unreasonable number of unused slide master. [Clean Up] [x]" Some believe that this disruptive action needs an additional confirmation (at least undo should work), we pondered over an "Inspect" button and a "Help" button (that might clutter the infobar however). Hossein, this might be an interesting easyhack. If you agree, please add some code pointer.
*** Bug 162776 has been marked as a duplicate of this bug. ***
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dfa9af835c19a441a0d0aee58920bfad9e1cbe01 Related: tdf#159860 inform if there is > 100 master slides It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.