Bug 159983 - FILEOPEN ODS: Wrong text and cell background color
Summary: FILEOPEN ODS: Wrong text and cell background color
Status: RESOLVED DUPLICATE of bug 158989
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
Depends on:
Blocks:
 
Reported: 2024-03-01 11:06 UTC by Kevin Suo
Modified: 2024-06-01 12:37 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
bgcolor.ods (12.41 KB, application/vnd.oasis.opendocument.spreadsheet)
2024-03-01 11:06 UTC, Kevin Suo 		Details
screenshot (81.77 KB, image/png)
2024-03-01 11:07 UTC, Kevin Suo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Suo 2024-03-01 11:06:01 UTC 
Created attachment 192888 [details]
bgcolor.ods

Steps to Reproduce:
1. Open the test ods with LibreOffice 7.6.
2. Open with LibreOffice master daily build.

The background color and text color for cell B2 is wrong, see screenshot.

Bad in:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 78065e3798439dd790d1be5ac5c219477285c888
CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN
Calc: threaded

Good in 7.6 branch.
Comment 1 Kevin Suo 2024-03-01 11:07:12 UTC 
Created attachment 192889 [details]
screenshot

Upper is 7.6 and bottom is master.
Comment 2 Rafael Lima 2024-03-01 14:08:10 UTC 
I can confirm this in

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 52806e4c1e241d12419373cb0ed013356e12c4b8
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

Apparently, there was a change to how the Automatic color was handler throughout LibreOffice. I guess Heiko worked on it for bug 156182.

@Heiko, what's your take on this issue?
Comment 3 Heiko Tietze 2024-03-01 16:58:40 UTC 
Yes, intentionally done for bug 156182.

(In reply to Kevin Suo from comment #0)
> Good in 7.6 branch.
Bad in 7.6 because of low contrast ;-)
Comment 4 Kevin Suo 2024-03-01 17:26:46 UTC 
Oh? It was a bug when the auto text color is unreadable in bug 156182, but it is not a bug when it is not readable in *this* one...
Comment 5 Heiko Tietze 2024-03-04 08:42:03 UTC 
(In reply to Kevin Suo from comment #4)
> Oh? It was a bug when the auto text color is unreadable in bug 156182, but
> it is not a bug when it is not readable in *this* one...
As a long-term user and contributor you know how we work. The mentioned bug improves readability by maintaining a reasonable contrast. The example should be striking. Your report claims that the automatic font color for some background is not black or white anymore (which is the intended result from the modification). Please define "not readable" here - and feel free to reopen.
Comment 6 Mike Kaganski 2024-06-01 12:29:09 UTC 
This is definitely a bug, and a regression. The fact that the change was intentional doesn't cancel the fact that it had unintended consequences to readability.

But let's just add it to bug 160719, instead of the opposite.

*** This bug has been marked as a duplicate of bug 160719 ***
Comment 7 Mike Kaganski 2024-06-01 12:30:14 UTC 

*** This bug has been marked as a duplicate of bug 158989 ***