Bug 160259 - Calc: Cell Comment indicator is hard to see
Summary: Calc: Cell Comment indicator is hard to see
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+ Master
Hardware: All macOS (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-18 16:09 UTC by steve
Modified: 2024-03-22 09:50 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot 2024-03-18 calc cell comment indicator (33.06 KB, image/png)
2024-03-18 16:09 UTC, steve
Details
Screenshot 2024-03-18 calc cell comment indicator with highlighted cell (17.05 KB, image/png)
2024-03-18 16:09 UTC, steve
Details
Numbers 13.2 cell comment good UX (17.89 KB, image/png)
2024-03-18 16:13 UTC, steve
Details
numbers no overlap of cell content and comment indicator (17.17 KB, image/png)
2024-03-19 15:15 UTC, steve
Details

Note You need to log in before you can comment on or make changes to this bug.
Description steve 2024-03-18 16:09:20 UTC
Description:
Compared to the red triangle indicating that cell content is cut-off by cell width, the cell comment indicator is farily small and due to its greyish color hard to see.

Visibility becomes even worse when the cell with a comment is highlighted making it close to impossible to see the indicator.

Steps to Reproduce:
add a comment to a cell and look at the cell comment indicator

Actual Results:
Very small indicator and hard to notice.

Expected Results:
Better visibility of cell comment indicator.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 479b5bbe8ca2177ba7574e7aa2308b5d0de1895c
CPU threads: 8; OS: macOS 13.6.5; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 steve 2024-03-18 16:09:33 UTC
Created attachment 193180 [details]
Screenshot 2024-03-18 calc cell comment indicator
Comment 2 steve 2024-03-18 16:09:50 UTC
Created attachment 193181 [details]
Screenshot 2024-03-18 calc cell comment indicator with highlighted cell
Comment 3 steve 2024-03-18 16:13:28 UTC
Created attachment 193182 [details]
Numbers 13.2 cell comment good UX
Comment 4 steve 2024-03-18 16:15:29 UTC
Added a screenshot of how Apple Numbers handles the situation. There are a few things they do well:

- cell comment indicator has good size
- cell comment indicator has a good color (contrast)
- the comment field emphasizes the comment (not wasting space putting author information first in bold and then the comment with small font second)

It would be great to take a few cues.
Comment 5 ady 2024-03-18 16:44:46 UTC
FWIW, ATM with 24.8 alpha…

* Menu Calc > Tools > Options > LibreOffice > Application Colors > (Spreadsheet) Comments. Change the color, or modify the Scheme (or change between System/Dark/Light on the upper right side corner).


* Menu Calc > Tools > Options > LibreOffice > Advanced > "Enable experimental features".

Menu Calc > Tools > Options > LibreOffice > Advanced > Open Expert Configuration >

Search for NoteIndicator


 org.openoffice.Office.Calc > Content > Display > NoteIndicator

Point the mouse on the value and read the tool tip.

Edit the value to, for instance, 100 (which is probably too big). Apply the new value and refresh the main screen (e.g. scroll). Play with whichever value you see fit for your system.

Otherwise, the default "dynamic" behavior means the size of the comment indicator changes according to Calc's zoom factor.


Since we are talking about 24.8 *alpha*, all this might change at any time.
Comment 6 steve 2024-03-18 20:16:20 UTC
For reference, the screenshots were created with a zoom factor of 100 %.
Comment 7 Telesto 2024-03-18 20:46:33 UTC
I first assumed it to be some HiDPI issue, but it's also tiny on my Windows machine with LoDPI screen
Comment 8 Heiko Tietze 2024-03-19 08:34:16 UTC
See bug 154080, bug 158958, and bug 159124 for the reason of this change. => NAB
Comment 9 steve 2024-03-19 15:15:24 UTC
Created attachment 193199 [details]
numbers no overlap of cell content and comment indicator

Thanks for linking the bugs.

https://bugs.documentfoundation.org/show_bug.cgi?id=154080 is about customizing the color of the indicator. it also mentions "he comment indicator is much too small and easy to miss".

https://bugs.documentfoundation.org/show_bug.cgi?id=158958 complains about comment indicator overlapping with cell content. That's a valid complaint. The assumption that making the comment indicator so small that it is barely visible or not visible at all when the cell is highlighted is not the solution to that problem.
Looking at Apple Numbers it becomes clear that adding a cell padding to the left and right of the cell border would resolve that problem much more elegantly.

https://bugs.documentfoundation.org/show_bug.cgi?id=159124 seems unrelated to comment indicator size.
Comment 10 Stéphane Guillou (stragu) 2024-03-21 07:25:28 UTC
Maybe something that would help with this recurring issue is mimicking that cell cursor / cell selection outline _outside_ the cell (and cell border), as Numbers does. That way, it would not overlap the comment indicator.
That's requested in bug 108240.
Comment 11 steve 2024-03-21 11:17:55 UTC
Imo that is only part of the solution. Overlapping UI elements should not happen indeed. But why is the indicator so tiny? Why did Apple opt to use a slightly bigger indicator? The reason size was decreased was, because (again) UI elements were overlapping. Back than that was about the indicator overlapping with cell content.

Instead of decreasing indicator, imo the proper solution would have been to add padding.

All of the above can be seen resolved in a good way when looking how Apple Numbers handled the situation:

- good size of indicator
- good color of indicator
- padding for cell content ensure no overlap
- outside highlight to avoid collision with UI elements inside of the cell
Comment 12 ady 2024-03-21 14:57:56 UTC
(In reply to steve from comment #11)

> But why is the indicator so tiny?

Finding a "good balance for everyone" is not so easy. While I agree that the default size could be _slightly_ bigger, making it "too big" would affect other users. We have been in this discussion before. Each user has its own opinions and preferences, according to personal preferences, visual aptitudes, screen, zoom factor, workflow...

> Instead of decreasing indicator, imo the proper solution would have been to
> add padding.

You can either follow the instructions I posted before in comment 5, or add padding yourself for your own spreadsheet.

For some reason, everyone that has some issue with comments thinks that his preference must be the solution for everyone else and it surely makes sense for it to be the default for everyone.

Regarding showing hints/tool-tip/indicators outside the relevant cell, please beware not to generate similar issues on adjacent cells, or overlapping different kinds of information.

@Heiko might want to spend some more time on a new balance (not as big as before, not as small as the current one). Or maybe he won't.
Comment 13 Heiko Tietze 2024-03-22 09:50:29 UTC
(In reply to ady from comment #12)
> @Heiko might want to spend some more time on a new balance (not as big as
> before, not as small as the current one). Or maybe he won't.
No, he wont. It's easyhackable for everyone though.

(In reply to Stéphane Guillou (stragu) from comment #10)
> cell selection outline _outside_ the cell ... as requested in bug 108240.
I'd commit to this task.