Bug 160402 - FILEOPEN DOCX Recognize localized paragraph style name used in StyleRef field
Summary: FILEOPEN DOCX Recognize localized paragraph style name used in StyleRef field
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:24.8.0 target:24.2.4
Keywords:
Depends on:
Blocks: DOCX-Fields
  Show dependency treegraph
 
Reported: 2024-03-27 22:22 UTC by Gabor Kelemen (allotropia)
Modified: 2024-09-13 07:47 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Word 2013 (18.78 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2024-03-27 22:22 UTC, Gabor Kelemen (allotropia)
Details
The example file in a German Word and English Writer (180.59 KB, image/png)
2024-03-27 22:24 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-03-27 22:22:49 UTC
Created attachment 193358 [details]
Example file from Word 2013

Attached example document was made in a German language Word 13.
It contains some StyleRef fields in the headers, which are set to use localized paragraph style names.
This works in Writer if the UI language is German, but not if it is anything else.
This behavior matches that of Word, but it would be really nice to support these style names if the files are opened in another locale.
This would be similar to what was implemented in bug 153083 for Table of Figures.

1. Open attached document
-> If the UI locale is German, all page headers show correct StyleRef field result
-> If the UI locale is not German, you get "Error: Reference source not found" messages.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0020fc1167b3760d0631001689a44427b72b816e
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: default
Comment 1 Gabor Kelemen (allotropia) 2024-03-27 22:24:11 UTC
Created attachment 193359 [details]
The example file in a German Word and English Writer
Comment 2 Stéphane Guillou (stragu) 2024-04-12 14:43:12 UTC
Reproduced in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d5dcc9de8ebce5d14be89ddeb6606ef0aeebf7a9
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

In the Edit Fields dialog, the field's type comes up as "Überschrift 1".
Comment 3 Commit Notification 2024-05-06 15:53:38 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ab1697cb4c17fd7a2fbf8d374ac95fc03b4d00be

tdf#160402 filter,writerfilter: import locale-dependent STYLEREF names

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2024-05-06 16:50:46 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d4fdafa103bfea94a279d7069ddc50ba92f67d01

tdf#160402 writerfilter,sw: STYLEREF field can refer to character style

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Michael Stahl (allotropia) 2024-05-06 16:53:44 UTC
fixed on master
Comment 6 Commit Notification 2024-05-07 07:34:55 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/72ea1005b987159a6a59f9379e63321e0b0dd44f

tdf#160402 writerfilter: extend StyleMap with all Word styles

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-05-07 08:05:01 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/e33f2b3d550d5d26a5eca135d88e0c16b2db11d8

tdf#160402 filter,writerfilter: import locale-dependent STYLEREF names

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-05-07 08:06:03 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/74f859b5525da0760a70ab660bd912dabfd608ca

tdf#160402 writerfilter,sw: STYLEREF field can refer to character style

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2024-05-07 10:00:35 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/331da18872d8dd526b0e91854450223ee8c0bf0c

tdf#160402 writerfilter: extend StyleMap with all Word styles

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.