Bug 160538 - Quickfind sidebar: ordering of results, Text in fields and frames comes first
Summary: Quickfind sidebar: ordering of results, Text in fields and frames comes first
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks: Sidebar-Find
  Show dependency treegraph
 
Reported: 2024-04-05 13:36 UTC by Heiko Tietze
Modified: 2024-06-12 19:47 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2024-04-05 13:36:29 UTC
Follow-up to bug 95405: content in fields and frames comes first, followed by regular paragraphs. Testing with formatted dummytext and "he".

https://extensions.libreoffice.org/en/extensions/show/132
Comment 1 Dieter 2024-04-20 10:19:53 UTC
I confirm it with

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7c2ed9919d6d9d286d9062b91577d6bb2b7de8aa
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

BTW: Thank you for that new feature!
Comment 2 Jim Raykowski 2024-06-08 02:20:20 UTC
(In reply to Heiko Tietze from comment #0)
> Follow-up to bug 95405: content in fields and frames comes first
Did you mean footnotes and frames?

Here is a patch that lists finds in frames in the order they are found in the document and finds footnotes and endnotes at the bottom of the results list:

https://gerrit.libreoffice.org/c/core/+/168566
Comment 3 Roman Kuznetsov 2024-06-08 18:06:36 UTC
(In reply to Jim Raykowski from comment #2)
> (In reply to Heiko Tietze from comment #0)
> > Follow-up to bug 95405: content in fields and frames comes first
> Did you mean footnotes and frames?
> 
> Here is a patch that lists finds in frames in the order they are found in
> the document and finds footnotes and endnotes at the bottom of the results
> list:
> 
> https://gerrit.libreoffice.org/c/core/+/168566

May be result from footnotes should be on the same place where would be its regular page and only results from endnotes should be on last places in the list?
Comment 4 Jim Raykowski 2024-06-10 00:16:47 UTC
(In reply to Roman Kuznetsov from comment #3)
> (In reply to Jim Raykowski from comment #2)
> > (In reply to Heiko Tietze from comment #0)
> > > Follow-up to bug 95405: content in fields and frames comes first
> > Did you mean footnotes and frames?
> > 
> > Here is a patch that lists finds in frames in the order they are found in
> > the document and finds footnotes and endnotes at the bottom of the results
> > list:
> > 
> > https://gerrit.libreoffice.org/c/core/+/168566
> 
> May be result from footnotes should be on the same place where would be its
> regular page and only results from endnotes should be on last places in the
> list?

Agree! Patchset 2 does this.
Comment 5 Heiko Tietze 2024-06-10 06:23:10 UTC
Much better. The content of an anchored object comes first, which makes the search jumpy at this point. But it's reasonable and I wouldn't put too much effort in this.
Comment 6 Commit Notification 2024-06-10 07:04:54 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/99ed68ac1fbaf883ddc730936299bba95d9e1d6f

tdf#160538 Quickfind sidebar list finds in frames and footnotes and

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.