Bug 160562 - Colibre's Images icon looks too dark shaded when insensitive in the Navigator (gtk3)
Summary: Colibre's Images icon looks too dark shaded when insensitive in the Navigator...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: low trivial
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks: Navigator GTK3 Icon-Theme-Colibre
  Show dependency tree / graph
 
Reported: 2024-04-06 07:14 UTC by Stéphane Guillou (stragu)
Modified: 2024-05-25 07:55 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
screenshot (34.03 KB, image/png)
2024-04-06 07:14 UTC, Stéphane Guillou (stragu) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2024-04-06 07:14:49 UTC 
Created attachment 193537 [details]
screenshot

Steps to reproduce:
1. Open Writer with OS in light mode
2. Tools > Options > LibreOffice > View > Icon Theme > pick Colibre > OK
3. Expand the Navigator Sidebar deck

Result: the greyed-out "Images" icon is the dark variant regardless of the UI theme. Inserting an image switches to the correct "active" icon.

Only happens with gtk3 VCL plugin.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 30c6e51fc9cb0fa864e1755271343d847fcced25
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Version: 7.4.0.3 / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL
Comment 1 Julien Nabet 2024-04-06 10:00:15 UTC 
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 2 Caolán McNamara 2024-04-06 14:19:39 UTC 
This image is
icon-themes/colibre/cmd/sc_insertgraphic.png
I don't think it is actually the dark variant, which is
icon-themes/colibre_dark/cmd/sc_insertgraphic.png
I think because its mostly explicitly white (and not transparent like the other) that when gtk makes it insensitive it appears mostly gray and too dark beside the others.
Comment 3 Commit Notification 2024-04-06 20:13:08 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5ebdcc60701ca5f2d267f92fa69ac06202309c52

Resolves: tdf#160562 change white background of icon to transparent

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Stéphane Guillou (stragu) 2024-04-12 15:44:33 UTC 
Thanks Caolán, fix verified in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d5dcc9de8ebce5d14be89ddeb6606ef0aeebf7a9
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded
Comment 5 Rizal Muttaqin 2024-05-25 07:55:45 UTC 
This bug report brings me to another question: Do we need to make Colibre (light) to remove all white background just like it's dark counterpart?