Bug 160646 - GIF don't animate in edit mode; are rendered as still images (Windows 8.1)
Summary: GIF don't animate in edit mode; are rendered as still images (Windows 8.1)
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha1+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0 target:24.8.0.2
Keywords: regression
Depends on:
Blocks: Images-Animated
  Show dependency treegraph
 
Reported: 2024-04-12 20:28 UTC by Telesto
Modified: 2024-07-18 16:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2024-04-12 20:28:54 UTC
Description:
GIF don't animate in edit mode; are rendered as still images

Steps to Reproduce:
1. Open attachment 159163 [details]


Actual Results:
Still images in edit mode

Expected Results:
Animated images in edit mode. Although still images being a lot better for performance 


Reproducible: Always


User Profile Reset: No

Additional Info:
Found in
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 748561425774fa40ab685fed80d113f7e8301158
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

and in
Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 898d5d470e24a55556f2fb244fec24df33ba8855
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded

Fine in
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 77befddec9486403c471b2beafd4ca0fd2429c5a
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 raal 2024-04-29 20:25:03 UTC
No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5740d3fa83e9725a2771e5f00ba4aaf9965f0be2
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo
Comment 2 Telesto 2024-05-03 18:54:06 UTC
Still the same with 
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9b41d33a00763bebd5fc70787052222d35a98a52
CPU threads: 4; OS: Windows 8.1 (6.3 build 9600); UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 3 raal 2024-05-04 11:03:50 UTC
(In reply to Telesto from comment #0)
> 
> Fine in
> Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community

adding tag Regression
Comment 4 Buovjaga 2024-06-12 18:31:40 UTC
(In reply to Telesto from comment #0)
> Found in
> Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 748561425774fa40ab685fed80d113f7e8301158
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
> Locale: nl-NL (nl_NL); UI: en-US
> Calc: CL threaded

They animate fine for me even in this exact same commit (with or without Skia):
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 748561425774fa40ab685fed80d113f7e8301158
CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

The difference is you are using Windows 8.1.
Comment 5 Telesto 2024-06-29 15:27:30 UTC
Everything fine, until GIF disappeared from canvas with
author	Noel Grandin <noelgrandin@gmail.com>	2021-04-16 20:33:10 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2023-07-25 08:38:12 +0200
commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 (patch)
tree ae1750e92421ad2e0ec3f50351c3be6581841598
parent dabedcaf27b0af1e38a611b8d8e48444f848e01d (diff)
Convert internal vcl bitmap formats transparency->alpha (II)
(Second attempt at landing this)

Image formats and graphics APIs use alpha, not transparency,
so change our internal formats and data structures to work directly
with alpha, so we don't need to modify data before we push it to
graphics APIs.

Add a couple of new Color constants to make the intention
of the vcl code clearer.

Notes
(*) On macOS, tweaking the logic in CreateWithSalBitmapAndMask
to more accurately reflect the requirements of the
CGImageCreateWithMask function seems to fix some
tests.

(*) The vcl code does not properly support gradients
with transparency. So the previous code was wrong, and this
change is going to result in slightly different wrongness.


----------------------------------------------------
A single frame of the gif became visible with
author	Patrick Luby <plubius@neooffice.org>	2023-11-03 10:37:00 -0400
committer	Patrick Luby <plubius@neooffice.org>	2023-11-03 18:32:26 +0100
commit 2a5dac6d75b346a77652dec05cafa6562177d40f (patch)
tree 0d6f525df92a046d42664d5e951c4d483c82b5b1
parent af9b546cf5eef3df417e225c8ad87283ab51e1bb (diff)
tdf#158047 allow the tdf#157635 fix for palettes with 64 entries

---
With Master: Insert -> Image actually inserts only a frame of the gif . So even older version won't show a animating gif
Comment 6 Commit Notification 2024-07-17 10:50:36 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b7b1013fa7ce85090763565426d10cb6435e4a53

fix skia crash (tdf#160646 related)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-07-18 05:43:31 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/e0dec49500194390c37e8513de37dd305c26e9c4

fix skia crash (tdf#160646 related)

It will be available in 24.8.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.