Bug 160717 - SVG import: wrong calculation of tspan's dy using ex
Summary: SVG import: wrong calculation of tspan's dy using ex
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:24.8.0 target:24.2.4
Keywords:
Depends on:
Blocks: SVG-Import
  Show dependency treegraph
 
Reported: 2024-04-18 09:33 UTC by Mike Kaganski
Modified: 2024-06-10 11:00 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2024-04-18 09:33:28 UTC
The fix for bug 160594 (https://gerrit.libreoffice.org/c/core/+/166234) uncovers the wrong handling of ex in dy attribute, identical to what was happening for em in bug 160593.

With https://gerrit.libreoffice.org/c/core/+/166234 applied, open attachment 193581 [details] in a browser and in Draw; the second line "bar" is rendered much closer to the first line in the browser, than in Draw.
Comment 1 Mike Kaganski 2024-04-18 09:34:23 UTC
https://gerrit.libreoffice.org/c/core/+/166235
Comment 2 Commit Notification 2024-04-19 03:19:07 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/edef46e82e7e54a27004f9ee6e99108390736d12

tdf#160717: fix ex handling

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Xisco Faulí 2024-04-19 08:34:15 UTC
Verified in

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 8df17c340193c89549d8c563b04d015156afa3fb
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Mike, thanks for fixing the issue!!
Comment 4 Commit Notification 2024-04-19 13:32:27 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/0324cb1c85b6daab8abaf139ac6b372127b76f06

tdf#160717: fix ex handling

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.