Bug 160810 - Writer: comment thread broken for comments without selected text
Summary: Writer: comment thread broken for comments without selected text
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) release
Hardware: All All
: highest major
Assignee: Not Assigned
Whiteboard: target:24.8.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
Reported: 2024-04-24 14:27 UTC by Timur
Modified: 2024-05-23 12:43 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2024-04-24 14:27:11 UTC
In Writer, comment thread is broken from 24.2.
Expected: add replies to commments and have thread, delete thread removes all
Experianced: add replies to commments and have thread until save, after reopen see separate comments and that delete thread removes only a single comment
Comment 1 m_a_riosv 2024-04-24 15:32:22 UTC
Looks like.
Version: (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 2 raal 2024-04-24 20:03:30 UTC
This seems to have begun at the below commit in bibisect repository/OS linux-64-24.2.
Adding Cc: to Gökay Şatır ; Could you possibly take a look at this one?
 b970a50fba146993a9ca672d81a7297c2e433f0c is the first bad commit
commit b970a50fba146993a9ca672d81a7297c2e433f0c
Author: Jenkins Build User <tdf@maggie.tdf>
Date:   Thu Oct 5 16:49:03 2023 +0200

    source c0187d9f5e6ab5129b6fc4682555f2f8775d6f67

157019: SW comments: Provide parent / child relations without position. | https://gerrit.libreoffice.org/c/core/+/157019
Comment 3 Timur 2024-05-22 14:46:31 UTC
Should be fixed in 24.8+ with https://gerrit.libreoffice.org/c/core/+/167680.

There may be follow-up issues:
delete thread removes 1by1 so and Undo restores 1by1 but seems to thread
delete thread with tracked changes may not properly mark all, but works 
delete thread with tracked changes and undo may have issues
Comment 4 Timur 2024-05-23 12:43:41 UTC
WIP for single Undo starting from https://gerrit.libreoffice.org/c/core/+/167931