Bug 160849 - Not all reserved shortcuts have labels in Customize dialog
Summary: Not all reserved shortcuts have labels in Customize dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Customise-Dialog
  Show dependency treegraph
 
Reported: 2024-04-28 19:46 UTC by Cor Nouws
Modified: 2024-05-20 06:39 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot in LO 24.8alpha0+ on Ubuntu 22.04 + GNOME 42.9 (31.01 KB, image/png)
2024-05-16 01:06 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2024-04-28 19:46:00 UTC
(extract from bug 160845 - apologies Stuart :) )

Looking at Tools>Customize, tab Keyboard, Ctrl+F6 is not listed there.

And there will be more from:
- https://help.libreoffice.org/24.8/en-US/text/shared/guide/keyboard.html?&DbPAR=DRAW&System=UNIX
Comment 1 Stéphane Guillou (stragu) 2024-05-15 04:38:44 UTC
It is in the list but greyed out on Ubuntu 22.04 + GNOME 42.9 with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0dcaff6043e1f24ce0fa354dff80a86e40622247
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Same with gen and kf5 VCL plugins.

Is the issue that there is no description for what it does, Cor?

Buovjaga might be able to help as he had a closer look recently with e1c59fd539222973410dc6adcb8eac4abeeb9e6a.
Comment 2 Buovjaga 2024-05-15 06:11:01 UTC
Yeah, there it is in the help page Cor linked:
Press Ctrl+F6 to switch to the document.

and what I documented in the code:
Set focus to the document canvas/data source

So disabling is working as expected.

Cor: what is your problem exactly? You are not even seeing the shortcut, as disabled? If so, which operating system / VCL UI are you using?
Comment 3 Cor Nouws 2024-05-15 20:33:52 UTC
(In reply to Buovjaga from comment #2)
> Cor: what is your problem exactly? You are not even seeing the shortcut, as
> disabled? If so, which operating system / VCL UI are you using?
I would expect that Ctrl+F6 is listed with its function in the Customize dialog.
For me it is not: neither for the option LibreOffice, nor for the option Writer (active module)

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 05a1217921b7be283c6750a35b90e4feda6e993e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 4 Stéphane Guillou (stragu) 2024-05-16 01:06:05 UTC
Created attachment 194140 [details]
screenshot in LO 24.8alpha0+ on Ubuntu 22.04 + GNOME 42.9

(In reply to Cor Nouws from comment #3)
> (In reply to Buovjaga from comment #2)
> > Cor: what is your problem exactly? You are not even seeing the shortcut, as
> > disabled? If so, which operating system / VCL UI are you using?
> I would expect that Ctrl+F6 is listed with its function in the Customize
> dialog.
> For me it is not: neither for the option LibreOffice, nor for the option
> Writer (active module)
Sorry, for me it's still unclear. Do you see the shortcut greyed out as in my attachment, or is it not listed at all?

In the shortcut, one can see Ctrl+F4 is labelled even though it is greyed out, but Ctrl+F6 isn't labelled. This definitely needs fixing. Just unsure if Cor's issue is that Ctrl+F6 _isn't listed at all_.
Comment 5 Cor Nouws 2024-05-16 04:42:33 UTC
(In reply to Stéphane Guillou (stragu) from comment #4)
> Sorry, for me it's still unclear. Do you see the shortcut greyed out as in
> my attachment, or is it not listed at all?
Sorry that you had to ask again :)
It is greyed out as in your example.
Comment 6 Buovjaga 2024-05-16 05:15:02 UTC
Ok, then it is working as intended as it's a reserved shortcut.
Comment 7 Buovjaga 2024-05-16 05:17:10 UTC
Or is this a feature request that reserved shortcuts should display their associations? That does sound useful, but I imagine would need quite a bit of coding to pull off.
Comment 8 Stéphane Guillou (stragu) 2024-05-16 05:43:41 UTC
(In reply to Buovjaga from comment #7)
> Or is this a feature request that reserved shortcuts should display their
> associations?
I think that would be ideal.
What's the technical difference between Ctrl + F4 and Ctrl + F6 in the screenshot?
Comment 9 Buovjaga 2024-05-16 05:52:40 UTC
(In reply to Stéphane Guillou (stragu) from comment #8)
> (In reply to Buovjaga from comment #7)
> > Or is this a feature request that reserved shortcuts should display their
> > associations?
> I think that would be ideal.
> What's the technical difference between Ctrl + F4 and Ctrl + F6 in the
> screenshot?

I don't see such a label for Ctrl + F4, interesting.
Comment 10 Stéphane Guillou (stragu) 2024-05-16 06:33:53 UTC
(In reply to Buovjaga from comment #9)
> (In reply to Stéphane Guillou (stragu) from comment #8)
> > (In reply to Buovjaga from comment #7)
> > > Or is this a feature request that reserved shortcuts should display their
> > > associations?
> > I think that would be ideal.
> > What's the technical difference between Ctrl + F4 and Ctrl + F6 in the
> > screenshot?
> I don't see such a label for Ctrl + F4, interesting.
Even with scope changed from Writer to LibreOffice? I picked that one on purpose to show that some greyed-out shortcuts _do_ have a label.
Comment 11 Buovjaga 2024-05-16 06:38:11 UTC
(In reply to Stéphane Guillou (stragu) from comment #10)
> (In reply to Buovjaga from comment #9)
> > (In reply to Stéphane Guillou (stragu) from comment #8)
> > > (In reply to Buovjaga from comment #7)
> > > > Or is this a feature request that reserved shortcuts should display their
> > > > associations?
> > > I think that would be ideal.
> > > What's the technical difference between Ctrl + F4 and Ctrl + F6 in the
> > > screenshot?
> > I don't see such a label for Ctrl + F4, interesting.
> Even with scope changed from Writer to LibreOffice? I picked that one on
> purpose to show that some greyed-out shortcuts _do_ have a label.

If I change the scope I can see it.
Comment 12 Buovjaga 2024-05-16 17:50:25 UTC
The difference seems to be that officecfg/registry/data/org/openoffice/Office/Accelerators.xcu has

<node oor:name="F4_MOD1" oor:op="replace">
  <prop oor:name="Command">
    <value xml:lang="x-no-translate">L10N SHORTCUTS - NO TRANSLATE</value>
    <value xml:lang="en-US">.uno:CloseDoc</value>
  </prop>
</node>

Under
<node oor:name="SecondaryKeys">
  <node oor:name="Global">

and under

<node oor:name="Modules">
  <node oor:name="com.sun.star.frame.StartModule" oor:op="replace">

and

<node oor:name="com.sun.star.chart2.ChartDocument" oor:op="replace">

while the other reserved ones are missing from the file.

Indeed, if I add this under SecondaryKeys, Global:

<node oor:name="F1" oor:op="replace">
  <prop oor:name="Command">
    <value xml:lang="x-no-translate">L10N SHORTCUTS - NO TRANSLATE</value>
    <value xml:lang="en-US">.uno:HelpIndex</value>
  </prop>
</node>

I can see the Help label when in Customize/Keyboard/LibreOffice context.

Now how to find out all the .uno commands for the rest of the missing shortcuts?
Comment 13 Cor Nouws 2024-05-16 19:56:13 UTC
thanks Ilamiri & Stéphane for moving in this direction :)
Comment 14 Buovjaga 2024-05-20 06:39:34 UTC
One last note: for some of these shortcuts it will be tricky to conjure up a label because they don't have a .uno command, but special handling. See bug 160462 comment 6.