Bug 160852 - delete all comments in Impress (.uno:DeleteAllAnnotation) only deletes uneven-numbered comments
Summary: delete all comments in Impress (.uno:DeleteAllAnnotation) only deletes uneven...
Status: VERIFIED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: ImpressDraw-Comments
  Show dependency treegraph
 
Reported: 2024-04-29 05:11 UTC by Stéphane Guillou (stragu)
Modified: 2024-07-09 06:45 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
slides with several comments (12.95 KB, application/vnd.oasis.opendocument.presentation)
2024-04-29 05:11 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2024-04-29 05:11:10 UTC
Created attachment 193886 [details]
slides with several comments

Steps:
1. Open attachment, which has various numbers of comments on each slide
2. Expand one comment
3. In comment's dropdown menu, click "Delete all comments"

Result: only uneven comments are deleted (see comment text on each slide to confirm).

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2f5ab5b8e7bd7dd06e00153abb77a69e5d192dd2
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Not in 24.2.2 -> regression.

linux-64-24.8 bibisect repo's currently does not reproduce at 5740d3fa83e9725a2771e5f00ba4aaf9965f0be2, but I see Quikee's more recent a938ed2be520426ce7949c4fd30a6e7e31d7c279 and a0a581ead18f030f59d203539706de0230746cae and related.

Quikee, can you please have a look?
Comment 1 m_a_riosv 2024-04-29 20:52:35 UTC
Works for me with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ea43cbbb7371a743f470d949762a0e92f196e652
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 2 Stéphane Guillou (stragu) 2024-04-30 04:19:24 UTC
(In reply to m_a_riosv from comment #1)
> Works for me with
> Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: ea43cbbb7371a743f470d949762a0e92f196e652
That was before Quikee's commits quoted in comment 0.
Comment 3 gladys 2024-07-03 17:26:25 UTC
another way to see the bug in version 24.8
when selecting on all comments in dropdown menu( as step 3) in comment 0.
-Select on delete all comments by author,
-it will a crash,
-then press recover selected,
-it will only show 1 and 2
Comment 4 gladys 2024-07-03 18:04:39 UTC
bibisect in windows version 7.6. seem to point to comment: 75c0d7827625c683d52a9e2f3a7c514df890107b
Date: 	Tue Jan 31 08:59:09 2023
author: Tomaž Vajngerl <quikee@gmail.com>
message: sd: use XTheme to transport the theme to xmloff import/export


the latest update with git checkout master && git log -1:
commit aeca67238e26cd148083055e0f223753f7462c14	[log]
author	Hossein <hossein@libreoffice.org>	        Thu May 25 15:55:11 2023 
committer:Xisco Fauli <xiscofauli@libreoffice.org>	Fri Feb 16 19:25:51 2024 

message: tdf#155446 Fix problem with ccache on Windows
Comment 5 Buovjaga 2024-07-05 07:16:49 UTC
(In reply to gladys from comment #3)
> another way to see the bug in version 24.8
> when selecting on all comments in dropdown menu( as step 3) in comment 0.
> -Select on delete all comments by author,
> -it will a crash,
> -then press recover selected,
> -it will only show 1 and 2

We discussed this and Gladys created bug 161899, but I was testing with a 3-week old Windows master and it turned out fixed in a later build.

Also, Stéphane's original report no longer reproduces. While testing I did discover other weirdness that I might report.
Comment 6 Stéphane Guillou (stragu) 2024-07-09 06:45:34 UTC
Testing with linux-64-24.8, it started at a0a581ead18f030f59d203539706de0230746cae (build [0bb6c6377d05033848d0045ac4aca57ad19659be]).

commit a0a581ead18f030f59d203539706de0230746cae
author	Tomaž Vajngerl Fri Apr 19 15:34:06 2024 +0900
committer	Tomaž Vajngerl Fri Apr 26 10:44:05 2024 +0200
annot: moved more of Annotation and dependencies into svx
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166494

Indeed, not reproduced in recent master build.

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a74d99644626421fa8e4ba0728f876afe72f28e4
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded