Created attachment 194020 [details] Reproducer document This may be the same as bug 58521, I'm not yet sure. Steps to reproduce: 1) Open the attached DOCX file. 2) Look at the order of foot/endnotes. Expected result: "This is an endnote", then "This is a footnote" Actual result: "This is a footnote", then "This is an endnote" on a separate page.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/90f19126fa405a0632eae4ee8525b66bbce12625 tdf#160984 sw continuous endnotes: introduce an endnote section It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8bae684c93bd23bbe98707ba9cf75d1a39427131 tdf#160984 sw continuous endnotes: add a way to find the endnote section start It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 194053 [details] WIP patch A snapshot of local changes that I have to fix the bugdoc, but not yet pushing as I'm aware of unwanted side effects.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ab3416cad1dd4e706432f9b1a3592cec823c76b0 tdf#160984 sw continuous endnotes: fix testContinuousEndnotesMoveBackwards It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9c7acbc937b3b341c10187b837e09cc20399f04e tdf#160984 sw continuous endnotes: fix CppunitTest_sw_layoutwriter3 It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6885dcd7ec7b82a946d8344bfc27a3e88eecc44a tdf#160984 sw continuous endnotes: switch to a section-based layout It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d74fb6b571304b41c13b7a6dcdd2b853bfca7210 tdf#160984 sw continuous endnotes, DOC import: enable this unconditionally It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1ae5ea3f78cca11ba18f2dd1a06f875263336a3b tdf#160984 sw continuous endnotes: enable DOCX import It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The inline / continuous endnote part is now done, I think. The position of the endnote separator is still bad, I'll look at that.
Created attachment 194265 [details] Demo of bad vertical position of endnote content (Word is red, Writer is painted on top of it) Demo of the current bad vertical position of endnote content. Red is meant to disappear as fixes are done.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d1ddd136a1b0e452492464d58715eaec144fd811 tdf#160984 sw continuous endnotes: fix the endnote container's top margin It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 194306 [details] Demo of bad vertical position of endnote separator
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f1d0b4e34a1f467e9f54baa7ac31ca28fdae3efb tdf#160984 sw continuous endnotes: fix the endnote separator position It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 194324 [details] Demo of bad length of endnote separator Length is bad, then the foot/endnote separator will be good, I think.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/755f3bebd96ec7ae43b1dcf247f907b9c15c1995 tdf#160984 sw continuous endnotes: fix the endnote separator length It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3f2d0414686a8f9a042413c47c4c8ffa5d61f436 tdf#160984 sw continuous endnotes: fix crash on loading forum-mso-en-7731.docx It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2d2dd56e0b2dc708f1f758d7fc9a1263ff09b83c tdf#160984 sw continuous endnotes: DOCX: import <w:endnotePr> pos == sectEnd It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/566c7017a84e3d573de85a6d986b81d3f59de0fa tdf#160984 sw continuous endnotes: DOCX: export of <w:endnotePr> pos == sectEnd It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 194455 [details] Endnote continuation separator lengh mismatch One more misrender: the endnote continuation separator in Word is longer, see the attached visual diff (Word is red, Writer is rendered on top of it).
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6450159e0e7c5fac9c998087e99f3fec602ff84d tdf#160984 sw continuous endnotes: fix the endnote continuation separator len It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8f3e11dc9a4b3fd9ad1985d88b241df7bcb66fec tdf#160984 sw continuous endnotes: hide not functional UI in this mode It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b79b50c8f06a5c977451995b2d632e5738d7d335 tdf#160984 sw continuous endnotes: add enable/disable option UI It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
When the ContinuousEndnotes option is set this prevents footnote positioning options from being honoured or modified in the UI. Because this is now enabled by default for documents imported from DOC/DOCX, any such documents will be affected, including any ODT documents that have been round-tripped through DOCX. I have raised bug 163097 for this regression in 24.8. Presumably the underlying issue is related to the implementation of ContinuousEndnotes rather that it being enabled for DOCX, while disabling for affected documents would be an adequate workaround for users of footnotes who do not need continuous endnotes.