Bug 161001 - DOCX nested table popped out of surrounding table
Summary: DOCX nested table popped out of surrounding table
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
7.6.6.3 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:25.8.0 target:25.2.1 target:24...
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: DOCX-Tables
  Show dependency treegraph
 
Reported: 2024-05-09 02:42 UTC by nengxing_xu
Modified: 2025-03-07 11:49 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Image show error (189.91 KB, image/png)
2024-05-09 02:44 UTC, nengxing_xu
Details
source word file (151.17 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2024-05-09 02:44 UTC, nengxing_xu
Details
Minimal reproducer (35.53 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2024-06-10 14:06 UTC, Miklos Vajna
Details
PoC patch (1013 bytes, patch)
2024-06-10 14:07 UTC, Miklos Vajna
Details

Note You need to log in before you can comment on or make changes to this bug.
Description nengxing_xu 2024-05-09 02:42:52 UTC
Description:
Word to PDF, move table content up

Actual Results:
Word to PDF, move table content up

Expected Results:
Word to PDF conversion, table content correct


Reproducible: Always


User Profile Reset: Yes

Additional Info:
No more information
Comment 1 nengxing_xu 2024-05-09 02:44:19 UTC
Created attachment 194042 [details]
Image show error
Comment 2 nengxing_xu 2024-05-09 02:44:48 UTC
Created attachment 194043 [details]
source word file
Comment 3 Stéphane Guillou (stragu) 2024-05-09 05:31:31 UTC
Thanks for the report!

I can reproduce at fileopen in a recent daily build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92815f3a464b447898ecf52492247335228e4a72
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

...and 7.6.6, but not in 7.5.9 -> regression.

Also on Windows 11.

Bibisected with linux-64-7.6 repo to first bad build [1235fa4aa4d7ffa258bdffae06299ef14ce19016] which points to f1307f09e60e715877769e9fa12c0a6313fa0c1a which is a cherrypick of:

commit f74a6ef94ac957e4c146fc9923d30ce6bd31b5ce
author	Miklos Vajna 	Tue Feb 13 08:09:23 2024 +0100
committer	Miklos Vajna 	Tue Feb 13 10:00:30 2024 +0100
tdf#159453 sw floattable: fix unexpected overlap of in-header fly and body text
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163290

Miklos, can you please have a look?
Comment 4 Miklos Vajna 2024-06-10 14:06:17 UTC
Created attachment 194630 [details]
Minimal reproducer

I attach a smaller reproducer.
Comment 5 Miklos Vajna 2024-06-10 14:07:31 UTC
Created attachment 194631 [details]
PoC patch

I attach a naive patch that solves the problem, but then this makes

make -C sw -sr CppunitTest_sw_core_layout CPPUNIT_TEST_NAME=testSplitFlyNestedRowSpan

hang, so this needs more time.
Comment 6 Commit Notification 2025-01-21 10:17:07 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/524c266f0f0a3cdccfa9feecfba2a19c9a29b701

tdf#161001 sw floattable: require in-header/footer for non-follow-text-flow

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Miklos Vajna 2025-01-21 10:28:15 UTC
Turns out the originally proposed fix started to not have that un-investigated side effect, at least on master.
Comment 8 Commit Notification 2025-01-22 12:21:23 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/62af1be5b58f69f10fb1aaa300a5106d2382a785

tdf#161001 sw floattable: require in-header/footer for non-follow-text-flow

It will be available in 25.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2025-01-22 14:21:43 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/94113befe22a3698f6221efc1d402599b64aa024

tdf#161001 sw floattable: require in-header/footer for non-follow-text-flow

It will be available in 24.8.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.