Bug 161024 - FILESAVE: PPTX: Placeholders are saved as images
Summary: FILESAVE: PPTX: Placeholders are saved as images
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks:
 
Reported: 2024-05-10 11:14 UTC by Xisco Faulí
Modified: 2024-05-27 06:01 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
comparison before and after (49.86 KB, image/png)
2024-05-10 11:14 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2024-05-10 11:14:04 UTC
Created attachment 194069 [details]
comparison before and after

Steps to reproduce:
1. Open attachment 191992 [details] from bug 159219
2. Save to PPTX
3. Open the new generated file

-> Placeholder images are bigger than before. They are also seen in slideshow mode

Reproduced in

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 11c66ea0f49417a30aae1ff250f7f18ec797753e
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2024-05-10 11:14:53 UTC
Regression introduced by:

author	Mike Kaganski <mike.kaganski@collabora.com>	2024-01-17 21:21:24 +0600
committer	Mike Kaganski <mike.kaganski@collabora.com>	2024-01-18 05:28:38 +0100
commit 67ba6ccd5a75ee6ade0e6aaa8bdc33f651a0d82c (patch)
tree 240723531387ad7182c0208eabd34fab27c61bcd
parent 8b393bba91111bd4f8988457f3a78b0306462bf2 (diff)
tdf#140912, tdf#159219: fix import of graphic placeholder with custom prompt

Bisected with: bibisect-linux64-24.8
Comment 2 Mike Kaganski 2024-05-12 09:50:37 UTC
(In reply to Xisco Faulí from comment #1)
> regression introduced by:

Could you please specify, which change is specifically considered "regression", and why.

* Importing the document in 24.2.0 showed a similar picture; however, it showed one of the placeholders (the one with custom prompt) in the presentation (not correct). After the change, both aren't shown in presentation (as expected).
* Saving the document to a PPTX in 24.2.0 destroyed the second placeholder (with custom placeholder) altogether - it was missing in the document (not correct). The first one was exported as an image, so after reloading, it was shown in the presentation (not correct). After the change, it exports both as images with changed dimensions, and so, after reload, they show in presentation (not correct).

The pre-existing problem is round-trip of placeholders to PPTX. I do not see how the modified wrong behavior is a regression.
Comment 3 Xisco Faulí 2024-05-14 08:48:01 UTC
yep, it makes sense. Removing 'regression' keyword