Bug 161092 - Need better graphics for new bar-of-pie and pie-of-pie chart types
Summary: Need better graphics for new bar-of-pie and pie-of-pie chart types
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks: Icon-Themes Chart-Wizard Pie-and-Donut
  Show dependency treegraph
 
Reported: 2024-05-16 00:48 UTC by Stéphane Guillou (stragu)
Modified: 2024-10-15 21:17 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
placeholder images currently used in Chart Wizard, next to Sifr images (46.53 KB, image/png)
2024-05-16 00:48 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2024-05-16 00:48:24 UTC
Created attachment 194139 [details]
placeholder images currently used in Chart Wizard, next to Sifr images

New bar-of-pie and pie-of-pie chart types added for bug 50934 currently use placeholder graphics in the Chart Wizard (and the Chart sidebar deck).

We need new graphic variations that blend with each of the different icon themes (attachment shows how it clashes with Sifr (dark), but it applies to all themes).

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 658a212585c56540a17c41111e6829716d4ef4e3
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 Commit Notification 2024-05-23 01:14:27 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/eb3ae3234e098e1ee605624b0cac4c90436628d0

tdf#161092 Colibre: Graphics for bar-of-pie and pie-of-pie chart type

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2024-05-23 03:08:40 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a46736cfe6b5188e840129b6aa26fc2970893474

tdf#161092 Sukapura: Graphics for bar-of-pie and pie-of-pie chart type

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2024-05-23 06:15:01 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f45270827c8bb32c58790a75e3fec3770be6b16f

tdf#161092 Breeze: Graphics for bar-of-pie and pie-of-pie chart type

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2024-05-23 06:15:03 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/87734c11fd634b3123559b1994b179e96810dd7c

tdf#161092 elementary: Graphics for bar-of-pie and pie-of-pie chart type

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-05-23 06:16:06 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b1f4a39a326bcaf06068914c03c3dea6f9aeebd8

tdf#161092 Sifr: Graphics for bar-of-pie and pie-of-pie chart type

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-05-23 11:03:44 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9990ac8143e81241be311f117bd2133bdf0ea343

tdf#161092 KJ: Graphics for bar-of-pie and pie-of-pie chart type

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Stéphane Guillou (stragu) 2024-05-30 03:48:36 UTC
Thank you Rizmut!

Verified in:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 6084962f93efc005b6827edceae12d3170f17ccd
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Minor nitpicking: for Sifr and Breeze, it isn't evident from the icon that the subchart refers to the big slice. Would be better with the smaller slice on the right, in my opinion.
Comment 8 kurt.nordback@protonmail.com 2024-05-30 12:29:17 UTC
Thank you! These look much better.

One other minor nitpick: LO renders the "composite" slice in the left (primary) pie centered about the x axis. That means the connection lines are symmetric about the center of the graph. Some of the icons show the composite slice centered, but some don't. Ideally the icons would more closely mimic the actual rendering.