Bug 161182 - Advanced search and replace not finding direct formatted words (character highlight) or character style with coloured font effect
Summary: Advanced search and replace not finding direct formatted words (character hig...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.6.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 161530 (view as bug list)
Depends on:
Blocks: Find-Search
  Show dependency treegraph
 
Reported: 2024-05-20 07:48 UTC by Daniele
Modified: 2024-11-11 18:33 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Video of the bug (2.02 MB, video/mp4)
2024-05-20 07:48 UTC, Daniele
Details
test file (14.72 KB, application/vnd.oasis.opendocument.text)
2024-05-20 07:49 UTC, Daniele
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele 2024-05-20 07:48:52 UTC
Created attachment 194209 [details]
Video of the bug

Hi,

Bug: as of 24.2.2.2 possibly earlier, the advanced search does not find any word with a specific direct formatting. Tested with highlight.

What it should do: it should find words with a specific direct formatting

Reproduce:

Open the attached test document with two different highlighted words

Open (cmd alt F in Mac) the advanced search and replace, click on the search slot, then on format, then on highlighting then color, then on either one of the colors used in the example (yellow or lime), save, Find next. "Search key not found message" should be seen.
Comment 1 Daniele 2024-05-20 07:49:35 UTC
Created attachment 194210 [details]
test file
Comment 2 Stéphane Guillou (stragu) 2024-06-05 05:11:45 UTC
Reproduced as described in:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1f15d097cace14ca6e44e7652f460aa3fa7bd150
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3

Not reproduced in:

Version: 7.6.7.2 (X86_64) / LibreOffice Community
Build ID: dd47e4b30cb7dab30588d6c79c651f218165e3c5
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3

Bibisected with linux-64-24.2 to first bad build [16c3bfc6c06bd75b39794836ed2b93ed2e1b882c] which is:

commit 614dfb98cd4705b63bf1e525d3d34df9ce950ebb
author	Tomaž Vajngerl 	Sat Jul 29 15:48:35 2023 +0200
committer	Tomaž Vajngerl 	Tue Aug 01 08:16:03 2023 +0200
set finalColor of the ComplexColor in BorderLine and BrushItem
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155111

Interestingly, bug was also in 7.6 since the above commit's cherrypick 0210b5e8b32b17d1feac5a34593538a3451f82f4 (build [016d71b686f827ce2efcf451f8dfc2787452b182] in linux-64-7.6), but was later fixed in 7.6.2 by Maxim's 1345619e0b3c2825c2ae50ada2c209d4ad8461ad (build [a631e53f4ce99e678fb54439277f0260da82a4ae]).
Maxim's original 24.2 patch 8ffb8e164d9d350a1b9887d0a75e0a82892008ee did not help as it was merged _before_ Quikee's 614dfb98cd4705b63bf1e525d3d34df9ce950ebb!

So regression is still present in 24.2 and current master.

Quikee, can you please have a look?
(Maxim, you might be interested in how your commit somehow helped.)
Comment 3 Stéphane Guillou (stragu) 2024-06-27 16:55:28 UTC
*** Bug 161530 has been marked as a duplicate of this bug. ***
Comment 4 Stéphane Guillou (stragu) 2024-06-27 16:57:04 UTC
See also duplicate bug 161530, in which a character style that involves a coloured font effect is also not matched when searched.