Bug 161202 - Hiding a section containing a table leads to unintended page breaks
Summary: Hiding a section containing a table leads to unintended page breaks
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.2.2 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:24.8.0 target:24.2.5
Keywords: bibisected, bisected, regression
: 161285 (view as bug list)
Depends on:
Blocks: Section Writer-Page-Break
  Show dependency treegraph
 
Reported: 2024-05-21 18:29 UTC by Werner
Modified: 2024-07-08 17:39 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample document containing section with table (10.89 KB, application/vnd.oasis.opendocument.text)
2024-05-21 18:29 UTC, Werner
Details
PDF from sample document with section hidden (11.44 KB, application/pdf)
2024-05-21 18:31 UTC, Werner
Details
containing several sections (12.80 KB, application/vnd.oasis.opendocument.text-template)
2024-07-02 08:10 UTC, burkhard.kasten
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Werner 2024-05-21 18:29:49 UTC
Created attachment 194250 [details]
Sample document containing section with table

Hiding a section which contains a table causing at least one unintended page break directly after the hidden section.

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: x11
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded
Comment 1 Werner 2024-05-21 18:31:56 UTC
Created attachment 194251 [details]
PDF from sample document with section hidden
Comment 2 m_a_riosv 2024-05-21 23:43:19 UTC
Reproducible
Version: 24.2.2.1 (X86_64) / LibreOffice Community
Build ID: bf759d854b5ab45b6ef0bfd22e51c6dc4fb8b882
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
and with
Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: e3bd3c7e3178dc091fd002628f052666b4db3be6
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded


Regression.
Last one that works on my installed versions.
Version: 24.2.1.1 (X86_64) / LibreOffice Community
Build ID: 359ef544e625d2ffbfced462ab37bd593ca85fa7
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 3 Mike Kaganski 2024-05-27 04:08:37 UTC
*** Bug 161285 has been marked as a duplicate of this bug. ***
Comment 4 Mike Kaganski 2024-05-27 04:13:39 UTC
I would suspect my commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1.
Comment 5 raal 2024-05-28 16:13:07 UTC
This seems to have begun at the below commit in bibisect repository/OS linux-64-24.2.
 32afca5c36770ee3290d9d2a349eb534eb12bfd3 is the first bad commit
commit 32afca5c36770ee3290d9d2a349eb534eb12bfd3
Author: Jenkins Build User <tdf@maggie.tdf>
Date:   Mon Feb 19 13:24:30 2024 +0100

    source ff7f1b59e22092d8548459e75fe912db852f056f

163477: tdf#159565 prerequisite: make hidden sections have zero-height frames | https://gerrit.libreoffice.org/c/core/+/163477
Comment 6 Commit Notification 2024-05-29 11:17:42 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fc1e6a64bd0517a7e67f08860c29b44d030220eb

tdf#161202: lowers shouldn't move forward because of lack of space

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-06-04 09:21:10 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/6a7a5fad86e5fcb736286ecc01a561bc5f802d23

tdf#161202: lowers shouldn't move forward because of lack of space

It will be available in 24.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 burkhard.kasten 2024-07-02 08:10:11 UTC
Created attachment 195078 [details]
containing several sections

This problem ist NOT fixed (see attachment)
Comment 9 Mike Kaganski 2024-07-02 08:23:19 UTC
(In reply to burkhard.kasten from comment #8)
> This problem ist NOT fixed (see attachment)

Did you test using the version that contains the fix?
Comment 10 Werner 2024-07-05 10:20:01 UTC
Works for me. Thanks.

Version: 24.2.5.1 (X86_64) / LibreOffice Community
Build ID: 2ccb78ad6bdfe3f3356a7a7f294ec388775c5816
CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: x11
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded