Bug 161212 - With Tabbed UI, Image settings (in Image tab, Properties Sidebar and top menu) are greyed out when image selected
Summary: With Tabbed UI, Image settings (in Image tab, Properties Sidebar and top menu...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:24.2.4
Keywords: bibisected, bisected, regression
: 161410 (view as bug list)
Depends on:
Blocks: Notebookbar-Tabbed
  Show dependency tree / graph
 
Reported: 2024-05-22 11:33 UTC by surbun
Modified: 2024-11-23 21:25 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
file to illustrate bug (196.49 KB, application/vnd.oasis.opendocument.graphics)
2024-05-22 11:34 UTC, surbun 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description surbun 2024-05-22 11:33:14 UTC 
Description:
When user choose "tabbed" and many other options for user's interface, all parameters for an inserted image is grayed.

Only possibility is when user's interface is set to "standard toolbar".



Steps to Reproduce:
1.Open Draw
2.Choose "Tabbed" in "Menu" -> "View" -> "User Interface"
3.Insert any image
4.Select image
4.Go to sidebar
5.Choose "Image" to access image properties

Actual Results:
All properties are grayed

Expected Results:
All properties available in order to get set according to user's needs.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Bug affects 24.08,24.04 versions and also Windows 24.04 version.
Comment 1 surbun 2024-05-22 11:34:49 UTC 
Created attachment 194270 [details]
file to illustrate bug
Comment 2 Stéphane Guillou (stragu) 2024-05-22 14:15:17 UTC 
Thank you for the report.

This is indeed a regression in 24.2 (and still reproduced in a recent daily build). Color Mode, Brightness, Contrast, Transparency, Filter... are all greyed out in both the Sidebar and the Image tab.

Bibisected with linux-64-24.2 repo to first bad build [c98eb4eecfbe78c2b672e69ca450d2a333d0d588] which is:

commit e58e251756ecb0312cb6891d4df23e17ef8f6fcb
author	Justin Luth 	Mon Jul 17 15:43:39 2023 -0400
committer	Justin Luth 	Tue Jul 18 02:33:24 2023 +0200
tdf#126095 sd notebookbar: don't force table/media toolbar
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154559

Justin, can you please have a look?
Comment 3 Stéphane Guillou (stragu) 2024-05-22 14:21:22 UTC 
Same on Windows 11.
Comment 4 Justin L 2024-05-22 22:11:40 UTC 
Interesting. It works fine for Writer. I would have expected a similar result for tables then as well, but that doesn't seem to be affected either.

I'm just going to revert the patch. It can be tried again in master so that the next attempt could undergo a full QA cycle again.

https://gerrit.libreoffice.org/c/core/+/167970
Comment 5 Justin L 2024-05-23 12:20:33 UTC 
https://git.libreoffice.org/core/commit/5777b30375df6b34568cf88cc3701513635eace1

Revert "tdf#126095 sd notebookbar: don't force table/media toolbar"

It will be available in 24.2.5.
Comment 6 surbun 2024-05-27 14:36:30 UTC 
Hello,

Thanks a lot for your prompt reply and correction to this bug

Seems to be OK in the 24.8 alpha 1 version.

Faithfully
BS
Comment 7 Stéphane Guillou (stragu) 2024-06-04 06:59:32 UTC 
*** Bug 161410 has been marked as a duplicate of this bug. ***