Bug 161214 - Callout shape remains on the screen after delete key was pressed
Summary: Callout shape remains on the screen after delete key was pressed
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.2.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0 target:24.2.5
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Shapes
  Show dependency treegraph
 
Reported: 2024-05-22 12:11 UTC by YCLEE
Modified: 2024-06-03 11:50 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
reproduced on my data (308.22 KB, video/mp4)
2024-05-22 12:32 UTC, YCLEE
Details
attached sample (54.00 KB, application/vnd.oasis.opendocument.spreadsheet)
2024-05-23 13:12 UTC, YCLEE
Details

Note You need to log in before you can comment on or make changes to this bug.
Description YCLEE 2024-05-22 12:11:25 UTC
Description:
After pressing the delete key on the Callout Shape, the image remains on the screen, making the user think that it was not deleted, and try to do it again, but "cant remove", because it has already been deleted, to remove it, the spreadsheet has to scroll up or down to refresh the rows.

Steps to Reproduce:
1. create a Callout Shape on the spreadsheet
2. type in text
3. select the Callout Shape
4. Press delete key
5. Image remains on the screen
6. scroll up down to remove it

Actual Results:
after pressing the delete key, the image is supposed to be gone, but its there, having the user thinking its not deleted 

Expected Results:
image removed after pressing delete key


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 28; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-SG (en_SG); UI: en-US
Calc: threaded
Comment 1 YCLEE 2024-05-22 12:32:08 UTC
Created attachment 194274 [details]
reproduced on my data

reproduced on my data
realise it happens on reopened spreadsheet but not on current working spreadsheet
Comment 2 m_a_riosv 2024-05-22 23:48:11 UTC
Please, could you attach a sample file?
Comment 3 YCLEE 2024-05-23 13:12:11 UTC
Created attachment 194308 [details]
attached sample

3 sheets with Callout Shape

click on it and press DEL key, the Callout image remains on the screen, and the only way to get rid of the image is to scroll up and down
Comment 4 YCLEE 2024-05-23 13:13:05 UTC
(In reply to m_a_riosv from comment #2)
> Please, could you attach a sample file?


as attached
Comment 5 ady 2024-05-23 14:25:10 UTC
Repro in:

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: threaded


but not in recent 24.8 alpha:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: e3bd3c7e3178dc091fd002628f052666b4db3be6
CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: threaded


nor in 7.6 ("temporal" regression):

Version: 7.6.6.3 (x86) / LibreOffice Community
Build ID: d97b2716a9a4a2ce1391dee1765565ea469b0ae7
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: CL threaded


Maybe some cherry-pick back-port is needed? And based on which report/commit?

I'm not sure whether to set this as NEW and REGRESSION.
Comment 6 Steve271 2024-05-29 20:57:09 UTC
I can confirm that the bug is present in:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

I also noticed that if you click on the shape, it does not automatically highlight the shape reference in the Sidebar’s Navigator section as it does in other versions of LO.


Also, this bug is not reproducible in:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: ae798781ef4df7a1fdef13af0bc459bf4f6e7b4c
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded


(In reply to ady from comment #5)

> I'm not sure whether to set this as NEW and REGRESSION.

I'm wondering the same @ady should this bug status be NEW, REGRESSION or RESOLVED WORKSFORME since it’s no longer present in 24.8.0.0.alpha ?
Comment 7 ady 2024-05-29 23:01:11 UTC
(In reply to ady from comment #5)

> Maybe some cherry-pick back-port is needed? And based on which report/commit?
> 
> I'm not sure whether to set this as NEW and REGRESSION.

Either someone bibisects:
* which was the commit that broke this; and,
* which was the commit that solved it for LO 24.8 in order to attempt some back-port;

...so users of LO 24.2 will benefit from it, or otherwise time will do what time does.

I am marking this as NEW and REGRESSION for now. It will be either solved in time, or at some point it will be marked as WFM when LO 24.2 will get to EOL.
Comment 8 Aron Budea 2024-06-02 21:15:08 UTC
The bug was reproducible in Linux with VCL plugin gen, at least in 24.2 bibisect builds, for some reason not in 24.8, even at oldest (but the fix could be reverse-bibisected in Windows).

This started from the same commit as bug 160589:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=596c53b06cbb33d312d58572b61e966e913109f3
author		Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de>	2023-11-30 15:33:07 +0100
committer	Armin Le Grand <Armin.Le.Grand@me.com>	2023-11-30 19:52:41 +0100

"Make ScOutputData::DrawSelectiveObjects compatible"

It was fixed by this commit in 24.8, which hasn't been backported, yet:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1e1a3825d76ed8071424e8e21bbda23464c10fff
author	Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de>	2024-04-16 16:26:07 +0200
committer	Armin Le Grand <Armin.Le.Grand@me.com>	2024-04-16 18:12:25 +0200

"tdf#160589: compare the correct OutDev with PageWindows"

I've initiated backport:
https://gerrit.libreoffice.org/c/core/+/168317
Comment 9 ady 2024-06-03 11:47:11 UTC
(In reply to Aron Budea from comment #8)

> It was fixed by this commit in 24.8, which hasn't been backported, yet:
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=1e1a3825d76ed8071424e8e21bbda23464c10fff
> author	Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de>
> 2024-04-16 16:26:07 +0200
> committer	Armin Le Grand <Armin.Le.Grand@me.com>	2024-04-16 18:12:25 +0200
> 
> "tdf#160589: compare the correct OutDev with PageWindows"
> 
> I've initiated backport:
> https://gerrit.libreoffice.org/c/core/+/168317


BEWARE: By now, there might be some overlapping or conflict between:

* https://gerrit.libreoffice.org/c/core/+/168317

* https://gerrit.libreoffice.org/c/core/+/166151
Comment 10 ady 2024-06-03 11:50:21 UTC
(In reply to ady from comment #9)

> BEWARE: By now, there might be some overlapping or conflict between:
> 
> * https://gerrit.libreoffice.org/c/core/+/168317
> 
> * https://gerrit.libreoffice.org/c/core/+/166151

I posted the above based on the now-back-ported patch tdf#160589 comment 12 that was not back-ported before.