Bug 161341 - Print dialog: hiding particular drawing shape does not work
Summary: Print dialog: hiding particular drawing shape does not work
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: Print-Dialog
  Show dependency treegraph
 
Reported: 2024-05-30 09:36 UTC by Gabor Kelemen (allotropia)
Modified: 2024-12-09 09:44 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
The issue in Writer 24.2 (28.00 KB, image/png)
2024-05-30 09:36 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-05-30 09:36:07 UTC
Created attachment 194451 [details]
The issue in Writer 24.2

This is followup to bug 161340
There is a "Sun 1" shape in the example file that can not be hidden from printing.

1. Open attachment 194449 [details] from bug 161340 in 24.2 or older
2. Open the Print dialog, go to the Writer tab
3.  Uncheck "Images and other graphic objects"
-> the Sun shape does not disappear from the preview.

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 14; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

and back to 3.3, not a recent regression.
Comment 1 Robert Großkopf 2024-05-30 15:22:30 UTC
How did you get this image into Writer? When opening the document with a packing program I see it is a *.png-image. But when oping Writer it doesn't show image properties. Seems to be a shape. But all shapes I draw in Writer will be hidden.
Comment 2 Buovjaga 2024-08-15 11:19:46 UTC
Currently the only shape that gets hidden is the one with the house. This changed in 24.8 with 6cdf523f179f3e7ed94267502a5fe3d1247398cc
[API CHANGE] tdf#158041 Remove unused drawing printing option from sw

Let's ask Samuel what he thinks.
Comment 3 Samuel Mehrbrodt (allotropia) 2024-08-15 11:45:36 UTC
I didn't intend to change functionality with above patch. If it does do that, feel free to revert it.
Comment 4 Buovjaga 2024-08-15 11:56:35 UTC
Now I see Gábor's 3735d43955a000db8b6fff04a2214793be649c4b
tdf#161340 Revert partially 6cdf523f179f3e7ed94267502a5fe3d1247398cc

So I will let him continue the partial reverting.
Comment 5 Commit Notification 2024-12-02 06:36:55 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ef4452663d13d0d559356440e71e97a6c282b1ff

tdf#161341 show/hide controls/shapes/pictures in view/print

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Gabor Kelemen (allotropia) 2024-12-09 09:44:18 UTC
Checked in 

Version: 25.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: ec4415d2a78b1c0fb5eab5baea88508d6b9db43b
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Now the image/shapes are hidden, a placeholder frame is displayed/printed in their place.
I'm not sure this is good enough, before this the drawings were just completely gone when hidden.