Bug 161345 - [24.8] When Application Color is a dark theme, Frame text boundary is no longer visible
Summary: [24.8] When Application Color is a dark theme, Frame text boundary is no long...
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks:
 
Reported: 2024-05-30 15:38 UTC by nobu
Modified: 2024-06-03 13:53 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nobu 2024-05-30 15:38:08 UTC
Description:
When Application Color is a dark theme, Frame border is no longer bright.

Steps to Reproduce:
1. Use a dark theme for the LibreOffice application colors.
2. Open a new Writer.
3. Insert a Frame.

Actual Results:
4. The border is dark.

Expected Results:
4. The border is bright.
Until version 24.2.3.2, it was lighter than the background color.


Reproducible: Always


User Profile Reset: No

Additional Info:
Reproducible with
Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 6084962f93efc005b6827edceae12d3170f17ccd
CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 10240); UI render: Skia/Raster; VCL: win
Locale: ja-JP (ja_JP); UI: ja-JP
Calc: threaded
Comment 1 m_a_riosv 2024-05-30 16:28:45 UTC
Reproducible
Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 6084962f93efc005b6827edceae12d3170f17ccd
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 2 Stéphane Guillou (stragu) 2024-06-03 13:36:20 UTC
This is actually about the line denoting the text area (i.e. the padding setting), which by default is not visible anymore in 24.8 - dark color scheme or not. The border of the object was already black before 24.8, and that's because it use Black instead of Automatic as a default border color.

Change bibisected with linux-64-24.8 to build [e906c2b0f23a9307c768fa9cc7b60a8acae5c995] which is:

commit 5bf7df62645f73ad69772f318ea3058dfd6fce12
author	Justin Luth 	Mon Mar 25 16:01:44 2024 -0400
committer	Miklos Vajna 	Tue Mar 26 13:29:13 2024 +0100
tdf#131253 sw: draw frame text boundary on when show formatting marks
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165294

So that was done on purpose, and makes sense: if you want to see such a text boundary, just like the page's text boundary, turn it on with View > Formatting Marks.
Comment 3 Stéphane Guillou (stragu) 2024-06-03 13:53:10 UTC
(In reply to Stéphane Guillou (stragu) from comment #2)
> The border of the object was already black before 24.8, and
> that's because it use Black instead of Automatic as a default border color.
Reported in bug 161392.