Bug 161349 - FILEOPEN: Header/Footer not displayed
Summary: FILEOPEN: Header/Footer not displayed
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:25.2.0 target:24.8.4
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Header-Footer
  Show dependency treegraph
 
Reported: 2024-05-30 18:31 UTC by Xisco Faulí
Modified: 2024-11-04 12:50 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparsion MSO vs LibreOffice 24.8 master (94.96 KB, image/png)
2024-05-30 18:31 UTC, Xisco Faulí
Details
088_Original_minimal.docx (56.18 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2024-11-02 19:36 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2024-05-30 18:31:36 UTC
Created attachment 194462 [details]
Comparsion MSO vs LibreOffice 24.8 master

Steps to reproduce:
1. Open attachment 91719 [details] from bug 73416
2. Go to the last page

-> Footer is not there

Reproduced in

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: c497cd602d543b48888212f79ba1ecf378e415fc
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 2 Xisco Faulí 2024-05-30 18:39:04 UTC
attachment 97680 [details] from bug 77725 is also affected where the header is not displayed
Comment 3 Dieter 2024-06-16 12:39:41 UTC
(In reply to Xisco Faulí from comment #0)
> Steps to reproduce:
> 1. Open attachment 91719 [details] from bug 73416
> 2. Go to the last page
> 
> -> Footer is not there

Xisco, is attachment the correct one? I can't see any footer in LO and in MSO 365. Attachment 194462 [details] is also not about footer I think.
=> NEEDINFO
Comment 4 Gabor Kelemen (allotropia) 2024-10-30 20:35:02 UTC
(In reply to Xisco Faulí from comment #2)
> attachment 97680 [details] from bug 77725 is also affected where the header
> is not displayed

I can confirm the missing header/footer with this file. Bibisect under Linux gives the same result as in comment #1, and under Windows:

  source 6329a56f601748f5a8dd6da9f0a90d3e57efcaf2
    source 66b30842e86fb6041bd6a453c6e3a877a3c177c1
    source 7cf3d5e3073dc5cffc64b6d9b32513e90087a3d4
    source 215a7afd6042c35a45509cea3eae69254d676429
    source 6b214f90bf6c66a7d2ed9cfb45ae8174e508fc45
    source a62436ff028c611542e86e8e87e92a844f5f4741
    source 7459d4eef300dd46bcac6ce52767541e475a5e93
    source 1c387bbf2fdf265c33c8eefbb769fae82b412769
    source 57ac7b73e898cf8889819d7f3beb3608e61b179b
    source 95017739a05c4f515fc42caebfd1e01e8a9ba160
    source bf269ed81fe2ec7c89a0f7d2d22e8e1982f558f4
    source cfc4a2cfd15760b1fc536c95c3570d916727c31b
    source f64d8d879e78fd3fdf593d3f29c16e5bf270a8cd
    source 833abb4a197561c34ec59cceb9d7d8a46f6b17ce
    source 4b0c46dc61df243cda94f4a0af8946e076d1af54
    source f1a780cb6b7b860856de7ce2d8735432523c9e73
    source af47a78e11d4819bb4b1ae1a1277babd10d815b7
    source 69bac9b78ce7dcbe91da3d3552aa3dd7edaf2b4a
    source 01e0931ba455a5ad9e1aa4b8ddd6951b6aa56902
    source 707344eaecbff672d7c837709d5c70d3eb04b6fd
    source ff516105c2df13cc71629b5a7156e16ec16b6988
    source 07521972bcd1cfbbd15b2f60ada84ffc69f8f997
    source d7cd7dff0e8f71b3d83b4c91b574f39248a25e2f
    source ed91971c9312e4b8a33c03c28d339bff6c5accc7
    source bbb0663813d0476b9a654207b7006315cb417c2e
    source 340f8ea4ae7f11b4d3a95499188a29fe801867cf
    source 27894455857eab436a7676de370a5bb897509f29
    source 8cd4cd31e9cffb593ccfba765fa28c2494a2d6f7
    source d04f64c0681c756386067f96b1cd9b89966d0e7c
    source d0e501021dac1a16d93e0e17235b399072d0058c
    source a5ad209d33b35958b40a7e2444ba0d9f061055ec
    source a67286aa0cf9c3bc5919343c428bb5485091104c
    source 684d63e133fddeca68055a83d85f75bd73319d39
    source d10fd2fd532d14500f67cebcc57a1b0f06786baa
    source 1b0f67018fa1d514ebca59e081efdd24c1d7811b
    source 2567f58f20cdc38b6ed92c639c0fcb19af84295f
    source c14574e7ad2d3ec2ada40808be3332fac71e9767
    source 178d8a38e133aebd4cff1af2d2c49aec60468c92
    source c9fc7f25a35a518360e6009edb2e03382122c836
    source 0426cb5bcc0b6d5132fc941514c59723ed327887
    source 01c7eefbb8722e2e5ef835777c2161b8e3d5aad8
    source b9946c42977fce2273e53e9dffe369dcab534856
    source f1cf1de6e844c1f46ebd4e5cfb552e7ce324dcbc
    source 097978b98f457e91643e5d8c65f48e21855851fd
    source 320b3603e4a82d072fc69df1f08127f8894b7bb6
    source 6361a9398584defe9ab8db1e3383e02912e3f24c
    source 864e752d9e876d29c54aba3b8fd57e4f71a02955
    source d505b8d2730b93cea8d2dcf2656af37c6c8cc580
    source cca4d8bdcd2ad54a0f353ebbcb26d5eb7b1087d8
    source 43f49c3b50b406f0334085dcf302180718f3ecb3
    source 7751ad7288138b3a62116544422df5a413ce6535
    source cfc0f4fae10859890c6e76d5a4ea11044b814da3
    source 2da4acdbf8c5a8ba3ef51e5f5dc3439716e71a91
    source 3da833827bd3efae2b5e0911cd6e2dd961c3ad89
    source ef9e1116d1100af50d7b74dcee5155c81b7b50fb
    source 2d2974f22ab59ea7dab1aee778308c4f50ff5464
    source 64ca3756416f0355b2008f39120e68ac42269784
    source 3297e7345d959b9f486f96167b200a2e13ffb059
    source 96e9c3a7fd2ce877d6d4d87c5333334790f7d85a

... not a lot better :(.
Comment 5 Gabor Kelemen (allotropia) 2024-10-30 23:17:58 UTC
Managed to bisect this properly under Linux by manually applying the patch

https://cgit.freedesktop.org/libreoffice/core/commit/?id=d04f64c0681c756386067f96b1cd9b89966d0e7c 

which fixed the linking error, which caused the bibisect repo to have a single build for the range in comment #1. The culprit seems to be:

https://git.libreoffice.org/core/+/c14574e7ad2d3ec2ada40808be3332fac71e9767

author	Justin Luth <justin.luth@collabora.com>	Sat Feb 03 10:08:56 2024 -0500
committer	Miklos Vajna <vmiklos@collabora.com>	Tue Feb 20 16:54:57 2024 +0100
tree 2ece091ae92f54604e671c1f7cfb7db153177ffb
parent 178d8a38e133aebd4cff1af2d2c49aec60468c92 [diff]

tdf#126533 docx import: page background vml fill

Adding CC to: Justin Luth
Comment 6 Justin L 2024-11-02 19:36:52 UTC
Created attachment 197357 [details]
088_Original_minimal.docx

Oh boy - this was a bad mistake. I was copying ALL attributes (including header on-off) instead of only the Fill attributes I was interested in.
Comment 7 Commit Notification 2024-11-03 00:40:46 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c8cfe6822f148d6f4ac545a9c66f17c4bcb1d9a3

tdf#161349 writerfilter: only copy page background vml fill

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-11-04 07:47:25 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/dde3872271389172a45cefc1eecff70f4ccb46b0

tdf#161349 writerfilter: only copy page background vml fill

It will be available in 24.8.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.