Bug 161478 - Insert button not working properly when using the insert more fields dialog
Summary: Insert button not working properly when using the insert more fields dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All All
: medium minor
Assignee: Caolán McNamara
URL:
Whiteboard: target:25.2.0 target:24.8.0.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Fields-Dialog
  Show dependency treegraph
 
Reported: 2024-06-08 19:57 UTC by Steve271
Modified: 2024-07-13 18:22 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
insert button (10.60 KB, application/vnd.oasis.opendocument.text)
2024-06-08 19:58 UTC, Steve271
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve271 2024-06-08 19:57:43 UTC
Description:
The insert button in the Fields dialog is grayed out, disabled and won't insert some field options that should be available.

Steps to Reproduce:
1. In the attached document, in the menu bar select Insert > Field > More Fields... (or press Ctrl + F2)
The Fields dialog menu will open and have the “Document” tab automatically selected and most of the types will be available to insert.

2. Select the “Cross-references” tab and on type select “Bookmarks” (or any other type that is not available). The insert button is grayed out since no bookmarks are available.

3. Then select the “Document” tab. The Insert button is grayed out for all the types that were previously available and you can’t insert them.

Actual Results:
The insert button is greyed out and disabled for some of the fields that should be available such as date and file name

Expected Results:
the insert button should not be greyed out and still be able to insert fields that are available


Reproducible: Always


User Profile Reset: No

Additional Info:
The workaround is to go back to the “Cross-references” tab and select a type that is available to activate the Insert button again.

This behavior is not present in older versions 3, 4 and 5


Reproducible starting in:

Version: 6.4.7.2 (x64)
Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

and

Version: 6.4.7.2
Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Steve271 2024-06-08 19:58:50 UTC
Created attachment 194610 [details]
insert button
Comment 2 Buovjaga 2024-06-17 15:25:32 UTC
Repro

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cfffcbc39b2c6794eaeddae5134fb59848a76d41
CPU threads: 8; OS: Linux 6.9; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: CL threaded
Comment 3 raal 2024-06-17 19:15:54 UTC
This seems to have begun at the below commit in bibisect repository/OS bibisect-linux-64-6.3.
Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one?
Thanks
 49446a9608822f992ad6f1a1a458c18157a28700 is the first bad commit
commit 49446a9608822f992ad6f1a1a458c18157a28700
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri Mar 22 15:09:50 2019 +0100

    source fbd79c6125fd302dde9af2d76171dd5ca794af4d

69475: weld SwFieldDlg | https://gerrit.libreoffice.org/c/core/+/69475
Comment 4 Commit Notification 2024-07-08 14:31:07 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7a5d0c413f37e02356d0bd1e1da7a9445ee25fe8

Resolves: tdf#161478 Insert button not updated on switch tabs

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Caolán McNamara 2024-07-08 15:13:33 UTC
that seems to fix it
Comment 6 Steve271 2024-07-12 03:29:38 UTC
Confirmed, this bug has been fixed and is no longer reproducible in:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 69fc5c396059603804b17b0f0cb076fff7188cba
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded


Good job
Comment 7 BogdanB 2024-07-12 03:39:22 UTC
Verified, based on comment 6.
Comment 8 Commit Notification 2024-07-13 18:22:25 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/157d71689ce1878a142118cdc7fd09b499cb07e3

Resolves: tdf#161478 Insert button not updated on switch tabs

It will be available in 24.8.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.