Bug 161502 - Calc: change Structure label of Function Wizard dialog
Summary: Calc: change Structure label of Function Wizard dialog
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha1+
Hardware: All All
: medium enhancement
Assignee: Bayram Çiçek
URL:
Whiteboard: target:25.2.0 target:24.8.0.0.beta2 t...
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2024-06-11 07:13 UTC by Bayram Çiçek
Modified: 2024-12-09 09:00 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Function Wizard dialog (27.13 KB, image/png)
2024-06-11 07:15 UTC, Bayram Çiçek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bayram Çiçek 2024-06-11 07:13:25 UTC
Description:
I see that we have twice the text "Structure" under the Structure tab of Function Wizard dialog. 

It will be good to rename the "Structure" label to something descriptive since the label does not give more information about the functions and users may not understand what is "structure" for.

("Structure" tab shows the validity of the passed parameters and the whole formula structure)

I suggest that renaming the label to something like:
 - "Functions in use and their validity:"
 - "Functions and their validity:"
 - etc...

or we can just remove the label.

Steps to Reproduce:
1. Open Calc
2. Click "Function Wizard" button on the toolbar
3. Click "Structure" tab.

You will see that there are 2 "Structure" strings on the UI.

Actual Results:
- "Structure" text used twice
- and does not give more info about the TreeView below.

Expected Results:
- change "Structure" text to something more descriptive.
- in this way we will get rid of the duplicated text "Structure"
- and users will have an idea what is the TreeView below the label


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: ff6553a0e44e7fb444f3baaacc690f69d4bba410
CPU threads: 32; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Bayram Çiçek 2024-06-11 07:15:28 UTC
Created attachment 194644 [details]
Function Wizard dialog

patch: https://gerrit.libreoffice.org/c/core/+/168612
Comment 2 Heiko Tietze 2024-06-11 07:30:02 UTC
Was thinking about a shorter label like "Content" or to just remove the label (only reason for the label is a11y).
Comment 3 Bayram Çiçek 2024-06-11 16:00:06 UTC
(In reply to Heiko Tietze from comment #2)
> Was thinking about a shorter label like "Content" or to just remove the
> label (only reason for the label is a11y).

Thank for the suggestion. I changed the label to "Content:" and uploaded a new patch. CI is green.
Comment 4 Commit Notification 2024-06-11 17:52:58 UTC
Bayram Çiçek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9bbb02bcd7cf26b3e69e12481ffd041019d76082

tdf#161502: change Structure label of Function Wizard dialog

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-06-11 23:11:46 UTC
Bayram Çiçek committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/1b88db8c1c0a92229a1998d4dcc4d5c488163f5a

tdf#161502: change Structure label of Function Wizard dialog

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-12-09 08:58:55 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/f45820f45e2cf351d3f08238952d25de0f68337d

tdf#161502 Update label Structure to Content in Function Wizard help
Comment 7 Commit Notification 2024-12-09 09:00:59 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/help/commit/700dad3c8ed1ce2cf73a96dab779f2f50caa7a01

tdf#161502 Update label Structure to Content in Function Wizard help