Bug 161748 - Copying cells in Calc doesn't show marching ants animation (at least on WindowsOS), neither in default configuration nor regardless of the expert option "AnimationsEnabled", when "Show animations in Windows" setting in WindowsOS is switched off.
Summary: Copying cells in Calc doesn't show marching ants animation (at least on Windo...
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha1+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-23 10:58 UTC by Per99
Modified: 2024-06-24 18:39 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Per99 2024-06-23 10:58:43 UTC
Description:
Copying cells in Calc does not show marching ants animation (at least on WindowsOS), neither in default configuration nor regardless of the expert option "AnimationsEnabled".

Despite the LibreOffice expert option "AnimationsEnabled", it does *not* use the "marching ants" animation, making it hard to see what cells you just selected, especially for visual impaired (e.g. elderly people), or just having bad light conditions.

The copied cells have not a "marching ants" animation copy border as before, but have just a "sleeping ants" border.
Note: the page break / print area also uses the same "sleeping ants" border, which is confusing to non-experts.

Therefore the default behaviour of copying cells should be the old "marching ants" animation.
I do understand that there might be people feeling annoyed by "marching ants" animation, but the option to switch on/off the animation ("AnimationsEnabled") must be respected.

The expert option "AnimationsEnabled" doesn't have an effect, neither “true” nor “false” activate the "marching ants" animation.
Expert option "AnimationsEnabled" specifically:
I changed this setting using: “Tools” ->  “Options” -> “LibreOffice” -> “Advanced” -> “Open Expert Configuration” -> Type: animat
"org.openoffice.Office.Common" -> "VCL" -> "AnimationsEnabled".  

This might be a Windows-only issue. It is still present in 24.2.4.2 and got introduced in 24.2.0.0.alpha1_Win_x86-64.msi.
However, in 7.6.7.2 the "marching ants" animation worked as usual.
Note: The bug is also present in 24.8.beta1.



Steps to Reproduce:
1. Use a windows-OS. My laptop has Win10Pro (Windows 10 Enterprise), 22H2 with all updates (Build: 19045.4529).  CPU threads: 4; OS: Windows 10.0 Build 19045; UI-Render: Skia/Raster; VCL: win,  Calc; threaded,  de-DE
2. (if needed) Install a parallel installation of 7.6.7.2 win x86_64
3. (if needed) Install a parallel installation of 24.2.4.2 win x86_64
4. Create a new calc document.
5. Select a group a cells and select "Copy"

Actual Results:
In 7.6.7.2: The copied cells have a "marching ants" animation border as usual.
In 24.2.4.2: The "marching ants" animation does not work: The copied cells have a "sleeping ants" border (the same as the page break / print area).

In 7.6.7.2: The expert option "AnimationsEnabled" gets respected: "true" means "marching ants" animation border. "false" means "sleeping ants" border.
In 24.2.4.2: The expert option "AnimationsEnabled" gets disregarded. Both "true" as well as "false" means "sleeping ants" border.

Expected Results:
1. The default behaviour should be that the copied cells have a "marching ants" animation as usual until and including 7.6.7.2.
2. The expert option "AnimationsEnabled" must get respected: "true" means "marching ants" animation border. "false" means "Sleeping ants" border.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
The bug (no "marching ants" animation) got introduced in LibreOfficeDev_24.2.0.0.alpha1_Win_x86-64.msi
There another change was introduced: the size of the “ants” were dependent of the size of the cell area selected. It doesn’t seem to be dependent on the zoom setting.

In 24.2.4.2 the size of the “ants” are small as usual, but there is still no "marching ants" animation border after copying.

See also the *fixed* bug report 156506: https://bugs.documentfoundation.org/show_bug.cgi?id=156506

See also the *fixed* bug report 155414: https://bugs.documentfoundation.org/show_bug.cgi?id=155414

My laptop has Win10Pro (Windows 10 Enterprise), 22H2 with all updates (Build: 19045.4529).  CPU threads: 4; OS: Windows 10.0 Build 19045; UI-Render: Skia/Raster; VCL: win,  Calc; threaded,  de-DE
Comment 1 Per99 2024-06-23 11:09:56 UTC
The bug might have been introduced in LibreOfficeDev_24.2.0.0.alpha0 but this isn't available for download (if it all exists).
Comment 2 m_a_riosv 2024-06-23 16:49:04 UTC
Works for me with
Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
and with
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 513c2bdbb1e7c0ad669d03043db61c94d6524aba
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

Not matter what is the Skia state.
Comment 3 ady 2024-06-23 16:50:34 UTC
No repro in:

Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: CL threaded

I see the marching ants, both when the advanced experimental features is not enabled at all, and also when it is enabled. When disabling the AnimationsEnabled item, the "ants" are static, not animated.

Please go to menu Help > About; there is an icon to copy information to the clipboard; press it and paste it in your next comment.

Please also test with menu Help > Restart in Safe Mode.
Comment 4 Per99 2024-06-23 20:49:03 UTC
(In reply to m_a_riosv from comment #2)
> Works for me with
> Version: 24.2.4.2 (X86_64) / LibreOffice Community
> Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
> CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL:
> win
> Locale: es-ES (es_ES); UI: en-US
> Calc: CL threaded
> and with
> Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: 513c2bdbb1e7c0ad669d03043db61c94d6524aba
> CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render:
> Skia/Raster; VCL: win
> Locale: es-ES (es_ES); UI: en-US
> Calc: CL threaded
> 
> Not matter what is the Skia state.

@m_a_riosv: Could you please repeat the tests with switched off "Show animations in Windows" in "Ease of Access" setting in WindowsOS? (For details, see below)

In previous versions including 7.6.7.2 the "Show animations in Windows" in "Ease of Access" setting in WindowsOS is disregarded.
Starting with LibreOfficeDev_24.2.0.0.alpha1_Win_x86-64.msi, this setting is suddenly used in LibreOffice (for just the "marching ants" animation).

Starting with LibreOfficeDev_24.2.0.0.alpha1, one is able to turn *off* the "marching ants" animation in LO by using the expert setting "AnimationsEnabled", regardless of the state of "Show animations in Windows".
However, the problem is, than one is not able to turn *on* the "marching ants" animation in LO by using the expert setting "AnimationsEnabled", regardless of the state of "Show animations in Windows".
For visual impaired people (e.g. elderly people), or just having bad light conditions, the "marching ants" animation is really helpful. The "Show animations in Windows" in "Ease of Access" setting in WindowsOS turns on all animations in WindowsOS and makes a slow computer even slower.


Details for "Show animations in Windows" in "Ease of Access" setting in WindowsOS:
(English: Windows OS -> Settings -> "Ease of Access" -> "Display" -> "Simplify and personalise Windows" -> "Show animations in Windows") 
(German: Windows OS -> Einstellungen -> "Erleichterte Bedienung" -> "Bildschirm" -> "Windows vereinfachen und personalisieren" -> "Animationen in Windows anzeigen").
Comment 5 Per99 2024-06-23 20:50:29 UTC
(In reply to ady from comment #3)
> No repro in:
> 
> Version: 24.2.4.2 (X86_64) / LibreOffice Community
> Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
> CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL:
> win
> Locale: en-US (es_AR); UI: en-US
> Calc: CL threaded
> 
> I see the marching ants, both when the advanced experimental features is not
> enabled at all, and also when it is enabled. When disabling the
> AnimationsEnabled item, the "ants" are static, not animated.
> 
> Please go to menu Help > About; there is an icon to copy information to the
> clipboard; press it and paste it in your next comment.
> 
> Please also test with menu Help > Restart in Safe Mode.

@ady: Could you please repeat the tests with switched off "Show animations in Windows" in "Ease of Access" setting in WindowsOS? (For details, see below)

In previous versions including 7.6.7.2 the "Show animations in Windows" in "Ease of Access" setting in WindowsOS is disregarded.
Starting with LibreOfficeDev_24.2.0.0.alpha1_Win_x86-64.msi, this setting is suddenly used in LibreOffice (for just the "marching ants" animation).

Starting with LibreOfficeDev_24.2.0.0.alpha1, one is able to turn *off* the "marching ants" animation in LO by using the expert setting "AnimationsEnabled", regardless of the state of "Show animations in Windows".
However, the problem is, than one is not able to turn *on* the "marching ants" animation in LO by using the expert setting "AnimationsEnabled", regardless of the state of "Show animations in Windows".
For visual impaired people (e.g. elderly people), or just having bad light conditions, the "marching ants" animation is really helpful. The "Show animations in Windows" in "Ease of Access" setting in WindowsOS turns on all animations in WindowsOS and makes a slow computer even slower.


Details for "Show animations in Windows" in "Ease of Access" setting in WindowsOS:
(English: Windows OS -> Settings -> "Ease of Access" -> "Display" -> "Simplify and personalise Windows" -> "Show animations in Windows") 
(German: Windows OS -> Einstellungen -> "Erleichterte Bedienung" -> "Bildschirm" -> "Windows vereinfachen und personalisieren" -> "Animationen in Windows anzeigen").
Comment 6 Per99 2024-06-23 20:52:43 UTC
(In reply to ady from comment #3)
> No repro in:
> 
> Version: 24.2.4.2 (X86_64) / LibreOffice Community
> Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
> CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL:
> win
> Locale: en-US (es_AR); UI: en-US
> Calc: CL threaded
> 
> I see the marching ants, both when the advanced experimental features is not
> enabled at all, and also when it is enabled. When disabling the
> AnimationsEnabled item, the "ants" are static, not animated.
> 
> Please go to menu Help > About; there is an icon to copy information to the
> clipboard; press it and paste it in your next comment.
> 
> Please also test with menu Help > Restart in Safe Mode.

Details of my parallel installations of LO: 
(the were freshly installed with a new user profile in: UserInstallation=$ORIGIN/../Data/settings )
Testing restarting in Safe Mode with hardware acceleration turned off produced the same result (with 24.2.4.2 and 24.8.0.0.beta1+)

Version: 24.8.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: dcaf9c147a1cfea268db49952171338555379794
CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
**********************************************************

Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
Comment 7 Per99 2024-06-23 20:54:32 UTC
This is an update to this bug report:

The old behaviour ("marching ants" animation) was still working in 7.6.7.2.

The bug (the new behaviour: no "marching ants" animation (under a certain condition, see below)) was introduced in LibreOfficeDev_24.2.0.0.alpha1_Win_x86-64.msi

A short summary first:
In previous versions including 7.6.7.2 the "Show animations in Windows" in "Ease of Access" setting in WindowsOS is disregarded.
Starting with LibreOfficeDev_24.2.0.0.alpha1_Win_x86-64.msi, this setting is suddenly used in LibreOffice (for just the "marching ants" animation).

Starting with LibreOfficeDev_24.2.0.0.alpha1, one is able to turn *off* the "marching ants" animation in LO by using the expert setting "AnimationsEnabled", regardless of the state of "Show animations in Windows".
However, the problem is, than one is not able to turn *on* the "marching ants" animation in LO by using the expert setting "AnimationsEnabled", regardless of the state of "Show animations in Windows".
For visual impaired people (e.g. elderly people), or just having bad light conditions, the "marching ants" animation is really helpful. The "Show animations in Windows" in "Ease of Access" setting in WindowsOS turns on all animations in WindowsOS and makes a slow computer even slower.


Suggestion:
Enable the user to turn on "marching ants" animation by either setting the expert setting "AnimationsEnabled" in LO to "true" or to switch on "Show animations in Windows" in "Ease of Access" setting in WindowsOS.
By this, the user is also able to turn off "marching ants" animation by setting the expert setting "AnimationsEnabled" in LO to "false" *and* to switch off "Show animations in Windows" in "Ease of Access" setting in WindowsOS.
The default behaviour in previous versions including 7.6.7.2 was to only use the expert setting "AnimationsEnabled", which default value is “true”.


Change request:
Changing the line of code: 
https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/overlayobject.cxx?r=9d68c794#41

mbAllowsAnimation = (officecfg::Office::Common::VCL::AnimationsEnabled::get() && !MiscSettings::GetUseReducedAnimation());

into:
mbAllowsAnimation = (officecfg::Office::Common::VCL::AnimationsEnabled::get() || !MiscSettings::GetUseReducedAnimation());

Before it makes sense to change the code, how do you see the above suggestion and change request?



Details for "Show animations in Windows" in "Ease of Access" setting in WindowsOS:
(English: Windows OS -> Settings -> "Ease of Access" -> "Display" -> "Simplify and personalise Windows" -> "Show animations in Windows") 
(German: Windows OS -> Einstellungen -> "Erleichterte Bedienung" -> "Bildschirm" -> "Windows vereinfachen und personalisieren" -> "Animationen in Windows anzeigen")

Further details:
Searching in the code for "AnimationsEnabled" I found (among others):
https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/overlayobject.cxx?r=9d68c794#41
Searching in the code for "GetUseReducedAnimation" I found (among others):
https://opengrok.libreoffice.org/xref/core/vcl/win/window/salframe.cxx?r=52a2c19f#3155
Searching the internet for "SystemParametersInfoW" I found (among others):
https://stackoverflow.com/questions/64872405/change-ease-of-access-settings-via-windows-api-systemparametersinfo
Where I found out how to change the return value of MiscSettings::GetUseReducedAnimation()

Actual Results:
In 7.6.7.2: The copied cells have a "marching ants" animation border as usual – regardless of the "Show animations in Windows" in "Ease of Access" setting in WindowsOS.

In 24.2.4.2: The "marching ants" animation does not work if "Show animations in Windows" in "Ease of Access" setting in WindowsOS is switched off.
The copied cells have a "sleeping ants" border (the same as the page break / print area).
In 24.8.0.0.beta1+: The same result as in 24.2.4.2.

In 7.6.7.2: The expert option "AnimationsEnabled" gets respected: "true" means "marching ants" animation border. "false" means "sleeping ants" border.
In 24.2.4.2: The expert option "AnimationsEnabled" gets disregarded when "Show animations in Windows" in "Ease of Access" setting in WindowsOS is switched off. Both "true" as well as "false" means "sleeping ants" border.
In 24.8.0.0.beta1+: The same result as in 24.2.4.2.
Testing restarting in Safe Mode with hardware acceleration turned off produced the same result as above (with 24.2.4.2 and 24.8.0.0.beta1+)


Expected Results:
1. The default behaviour should be that the copied cells have a "marching ants" animation as usual until and including 7.6.7.2 when the expert option "AnimationsEnabled" is “true” regardless of the "Show animations in Windows" in "Ease of Access" setting in WindowsOS.
2. The expert option "AnimationsEnabled" must get respected: "true" means "marching ants" animation border. "false" means "Sleeping ants" border when the "Show animations in Windows" in "Ease of Access" setting in WindowsOS is switched off.


Details of my parallel installations of LO: 
(the were freshly installed with a new user profile in: UserInstallation=$ORIGIN/../Data/settings )
Version: 24.8.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: dcaf9c147a1cfea268db49952171338555379794
CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
**********************************************************

Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded


Before it makes sense to change the code, how do you see the above suggestion and change request?

I don’t know how to update this bug report, especially the Actual Results and Expected Results. Is there a way or do I have to clone this bug report?
Comment 8 ady 2024-06-23 22:06:50 UTC
In LO 24.2, the MS Windows setting that allows (or not) animations impacts the behavior in Calc for "marching ants". This was not the case in LO 7.6.

The OS setting enables/disables _all_ animations, and I agree, that is not what some users need; some animations are not strictly necessary (making the OS slower) whereas others are really helpful for accessibility.

Basically, you are requesting that the "marching ants" behavior in LO should depend only on LO's settings, and not to depend on OS's settings.

FWIW, +1 from me.

CC'ing Michael.
Comment 9 Per99 2024-06-23 22:41:17 UTC
(In reply to ady from comment #8)
> In LO 24.2, the MS Windows setting that allows (or not) animations impacts
> the behavior in Calc for "marching ants". This was not the case in LO 7.6.
> 
> The OS setting enables/disables _all_ animations, and I agree, that is not
> what some users need; some animations are not strictly necessary (making the
> OS slower) whereas others are really helpful for accessibility.
> 
> Basically, you are requesting that the "marching ants" behavior in LO should
> depend only on LO's settings, and not to depend on OS's settings.
> 
> FWIW, +1 from me.
> 
> CC'ing Michael.

Yes, either
a) > Basically, you are requesting that the "marching ants" behavior in LO should depend only on LO's settings, and not to depend on OS's settings.

or
b) Enable the user to turn on "marching ants" animation by either setting LO's settings to "true" or switching on the OS's settings.
By this, the user is also able to turn off "marching ants" animation by setting the expert setting "AnimationsEnabled" in LO to "false" *and* to switch off "Show animations in Windows" in "Ease of Access" setting in WindowsOS.
The behaviour in previous versions including 7.6.7.2 (on a MS Windows PC) was to use only the expert setting "AnimationsEnabled", which default value is “true”.

In either case, it should be documented, how to turn on and off the "marching ants" animation.
Comment 10 ady 2024-06-23 23:24:37 UTC
(In reply to Per99 from comment #9)
> (In reply to ady from comment #8)
> > In LO 24.2, the MS Windows setting that allows (or not) animations impacts
> > the behavior in Calc for "marching ants". This was not the case in LO 7.6.
> > 
> > The OS setting enables/disables _all_ animations, and I agree, that is not
> > what some users need; some animations are not strictly necessary (making the
> > OS slower) whereas others are really helpful for accessibility.
> > 
> > Basically, you are requesting that the "marching ants" behavior in LO should
> > depend only on LO's settings, and not to depend on OS's settings.
> > 
> > FWIW, +1 from me.
> > 
> > CC'ing Michael.
> 
> Yes, either
> a) > Basically, you are requesting that the "marching ants" behavior in LO
> should depend only on LO's settings, and not to depend on OS's settings.
> 
> or
> b) Enable the user to turn on "marching ants" animation by either setting

The settings currently available in LO/Calc should give enough alternative customization (especially for accessibility reasons), and should prevail, IMNSHO.

FWIW, I disagree with your "b" (IIUC, which I'm not sure I do). One user might want the animated ants in Calc while the OS's setting for animation is OFF, and OTOH some other user might want the exact opposite case (for whichever reason). So, the behavior in Calc should rather be set by Calc settings, and not imposed (on any direction) by the OS's settings. At most, the OS's settings (as the user sets them) could be taken as the default for the program's behavior in that system, but then LO's settings should prevail (especially when they are modified/customized by the user). This is my personal opinion, not just in the case of animations.


@Per99,

As a side note, please try to be more concise, please avoid repeating what was already said, and please do not quote entire comments unnecessarily. TIA.
Comment 11 Per99 2024-06-24 18:05:25 UTC
The description of this bug report was written with wrong understanding (didn't know that the OS's animation setting overrides LO's expert setting "AnimationsEnabled"). Therefore the steps to reproduce the bug were incomplete.
So I close this bug and have opened a new bug report with a clearer description and steps to reproduce.
See tdf#161765.
Comment 12 Per99 2024-06-24 18:06:51 UTC
See tdf#161765.

*** This bug has been marked as a duplicate of bug 161765 ***
Comment 13 ady 2024-06-24 18:37:47 UTC
(In reply to Per99 from comment #12)
> *** This bug has been marked as a duplicate of bug 161765 ***

Marking this tdf#161748 as dupe of tdf#161765 is incorrect. I am closing this as INVALID. further discussions should be all done in the new tdf#161765.

The side note I wrote in comment 10 is still relevant for that ticket too.