Bug 161832 - Removing macro added to form control is greyed out
Summary: Removing macro added to form control is greyed out
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
7.5.5.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:25.2.0.2 target:25.8.0 target:...
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Form-Controls
  Show dependency treegraph
 
Reported: 2024-06-28 17:24 UTC by Robert Großkopf
Modified: 2024-12-22 20:55 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot with greyed out "Remove" for a macro of a form control (30.70 KB, image/png)
2024-06-28 17:24 UTC, Robert Großkopf
Details
Making the "Remove" button active (2.25 MB, image/gif)
2024-07-20 19:31 UTC, nutka
Details
test file (10.34 KB, application/vnd.oasis.opendocument.text)
2024-12-21 18:20 UTC, raal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2024-06-28 17:24:03 UTC
Created attachment 195042 [details]
Screenshot with greyed out "Remove" for a macro of a form control

Open a form for editing, could be a writer form, a Base form or something else.
Open a control where a macro has been added.
Click on the macro and have a look:
Button "Remove" is greyed out.
You could assign another macro, you could choose "Remove all", but you couldn't remove only one macro.

This bug appears in
Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 6; OS: Linux 6.4; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

Also in LO 7.6.4.1, also 7.5.5.2
Works well in LO 7.4.7.2 (last good working version for creating forms - too many bugs in newer versions)
Property to "Remove all" has been added in LO 7.5. Since this version the buggy behavior appears.
Comment 1 raal 2024-07-18 17:08:32 UTC
Works for me in Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2afdc61dd3138b383fb73dae2242ba1a9c8de901
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

Please, can you test in dev version?
Comment 2 Robert Großkopf 2024-07-19 19:33:27 UTC
Same buggy behavior in
Version: 24.8.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 318462181c709ed29c01eb3239b4d600d7b82ecc
CPU threads: 6; OS: Linux 6.4; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded
Comment 3 Robert Großkopf 2024-07-20 17:40:47 UTC
Same buggy behavior also in
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 553c128e3fdc4b9612c1150b30d7b89df2ae6fdd
CPU threads: 6; OS: Linux 6.4; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded
Comment 4 nutka 2024-07-20 19:29:35 UTC
Reproducible on Windows 11 with 24.8.0.1 and 25.2.0.0

Interestingly, the "Remove" button becomes active if I select any other event and reselect the original event (cf. the attached .gif recording).



Version: 24.8.0.1 (X86_64) / LibreOffice Community
Build ID: 6fd6cae02baed1e82d14ed2da1f2458092354dab
CPU threads: 8; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: en-US (pl_PL); UI: en-US
Calc: threaded


Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 553c128e3fdc4b9612c1150b30d7b89df2ae6fdd
CPU threads: 8; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: en-US (pl_PL); UI: en-US
Calc: threaded
Comment 5 nutka 2024-07-20 19:31:18 UTC
Created attachment 195408 [details]
Making the "Remove" button active
Comment 6 Robert Großkopf 2024-07-21 06:22:11 UTC
Confirmed by comment 4.

Same behavior here for activating "Remove" button.
Comment 7 raal 2024-12-21 17:51:40 UTC
This seems to have begun at the below commit in bibisect repository/OS linux-64-7.5.
Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one?
Thanks
 7891e1fe51b3aa4136116ed46ae74021ce1a91a9 is the first bad commit
commit 7891e1fe51b3aa4136116ed46ae74021ce1a91a9
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Sat Dec 10 11:18:38 2022 +0100

    source 006f7d03d6f29ae2d4a751bf86f399b4cad38313

143868: Related: tdf#152266 give feedback which events are assigned | https://gerrit.libreoffice.org/c/core/+/143868
Comment 8 raal 2024-12-21 18:20:27 UTC
Created attachment 198215 [details]
test file

Test file, where you can reproduce the bug. Not reproducible with every control.
Comment 9 Commit Notification 2024-12-22 12:07:10 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/93652d720881266ef5ce1ae68df35cbe87c9bec5

Resolves: tdf#161832 select row before update that depends on selection

It will be available in 25.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2024-12-22 13:11:21 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0920e5dd036f956ab3956a22e47edbd5f2d57071

Resolves: tdf#161832 select row before update that depends on selection

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2024-12-22 20:55:32 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/9f8c462b1f296c748c9749236405e87fe859935b

Resolves: tdf#161832 select row before update that depends on selection

It will be available in 24.8.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.