Bug 161986 - ODS fileopen got much slower in 7.4
Summary: ODS fileopen got much slower in 7.4
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: high normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords: bibisected, bisected, perf, regression
Depends on:
Blocks: Performance
  Show dependency treegraph
 
Reported: 2024-07-10 17:51 UTC by Timur
Modified: 2024-10-08 12:01 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
sample ODS (1.21 MB, application/vnd.oasis.opendocument.spreadsheet)
2024-07-10 17:51 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2024-07-10 17:51:13 UTC
Created attachment 195213 [details]
sample ODS

ODS fileopen got much slower in 7.4, from 15 to 90 seconds.

Bisected to:

commit 5e402bac39dc4245844efbde442bdb3bd993a157	[log]
author	Luboš Luňák <l.lunak@collabora.com>	Thu Feb 10 13:38:56 2022 
committer	Luboš Luňák <l.lunak@collabora.com>	Thu Feb 10 21:53:34 2022 
remove most hardcoded MAXCOL/MAXROW from Calc filters
Comment 1 m_a_riosv 2024-07-10 21:01:49 UTC
The issue look comes from the whole column A cells in CHART sheet are merged in one, also column A in Sheet8 is merged.
Unmerged them and the file is saved and loaded very quick.
Version: 24.2.5.1 (X86_64) / LibreOffice Community
Build ID: 2ccb78ad6bdfe3f3356a7a7f294ec388775c5816
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 2 Commit Notification 2024-10-02 12:00:58 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5f6b8b18dc16d290382187693861404e9a405b34

tdf#161986 speedup ODS with large merged range

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Noel Grandin 2024-10-02 12:01:33 UTC
I'm fairly sure there is more here that can be improved, but I don't understand the styles import well enough to make that happen
Comment 4 Timur 2024-10-08 12:01:55 UTC
Same machie now opens in 21 secs, which is comparable to previous 15 secs.
So for regression bug I close this with thanks to Noel.
Obviously this would need further improvment, but that would be Enhancement.