Bug 162006 - Autofill handle should have a white outline too
Summary: Autofill handle should have a white outline too
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.0 beta1+
Hardware: All All
: medium enhancement
Assignee: Rafael Lima
URL:
Whiteboard: target:25.2.0 target:24.8.1.2
Keywords: topicUI
Depends on:
Blocks:
 
Reported: 2024-07-11 20:09 UTC by Rafael Lima
Modified: 2024-08-31 02:12 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshots (53.83 KB, application/vnd.oasis.opendocument.graphics)
2024-07-11 20:10 UTC, Rafael Lima
Details
Screenshots (with cursor outline) (149.91 KB, image/png)
2024-07-15 20:48 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2024-07-11 20:09:05 UTC
Given the recent work to improve the contrast of the selection outline (see fix for bug 161204) using an internal white outline, it would be nice to have this white outline around the autofill handle as well.

Notice that this is what other apps do, such as Excel, Google Sheets and OnlyOffice (see attached ODG with screenshots).

So I propose we add this outline to the autofill handle as well.

In Page 2 of the attached ODG file I show a screenshot of a WIP with my proposal.
Comment 1 Rafael Lima 2024-07-11 20:10:06 UTC
Created attachment 195245 [details]
Screenshots

Here are the screenshots of OnlyOffice, Excel, Google Sheets as well as the proposed implementation for LO Calc.
Comment 2 Rafael Lima 2024-07-15 20:48:25 UTC
Created attachment 195322 [details]
Screenshots (with cursor outline)

Update screenshots of the patch comparing OnlyOffice, Excel Online and LO Calc (with the latest patch).
Comment 3 Commit Notification 2024-07-18 12:13:19 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1d1f47e6ca6367bf8fb828dd09cce197a96f643c

tdf#162006 Use contrast outline for the AutoFill/Cursor handle as well

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2024-08-30 11:57:33 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/0b5eedc5e98adcc9cff578a4a47a9d33adf7e579

tdf#162006 Use contrast outline for the AutoFill/Cursor handle as well

It will be available in 24.8.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-08-31 02:11:49 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-24-8-1":

https://git.libreoffice.org/core/commit/3284f5e49ef949be6dfd5bec640b6fb479907040

tdf#162006 Use contrast outline for the AutoFill/Cursor handle as well

It will be available in 24.8.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.