Bug 162990 - Oversized lock-icon with SVG themes
Summary: Oversized lock-icon with SVG themes
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
24.8.0.3 release
Hardware: All Linux (All)
: medium normal
Assignee: Buovjaga
URL:
Whiteboard: target:25.2.0 target:24.8.2
Keywords:
Depends on:
Blocks: Sidebar-Properties-Image Icon-Theme-Colibre
  Show dependency treegraph
 
Reported: 2024-09-16 12:35 UTC by Olivier Hallot
Modified: 2024-09-17 14:47 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Image shows ugly lock icon in Image properties sidebar (54.63 KB, image/png)
2024-09-16 12:35 UTC, Olivier Hallot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2024-09-16 12:35:48 UTC
Created attachment 196476 [details]
Image shows ugly lock icon in Image properties sidebar

Image attached says all...

The lock icon in the image properties sidebar in Writer is out of correct proportions and looks ugly in the user interface.


Version: 24.8.1.2 (X86_64) / LibreOffice Community
Build ID: 87fa9aec1a63e70835390b81c40bb8993f1d4ff6
CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (pt_BR.UTF-8); UI: pt-BR
Calc: threaded
Comment 1 Roman Kuznetsov 2024-09-16 17:59:04 UTC
Looks as always in Windows

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 976567aee323afd09629b6adf13537908f43d2a8
CPU threads: 16; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL threaded

may be only KDE bug?
Comment 2 V Stuart Foote 2024-09-16 18:27:03 UTC
Yep, no issue with icon size with the Windows builds.
Comment 3 Rafael Lima 2024-09-16 19:47:46 UTC
I am getting normal-sized lock icon both in 24.8 and 25.2 (master).

I am using Breeze Dark icons.

What icon set are you using?


Tested with 

Version: 24.8.2.0.0+ (X86_64) / LibreOffice Community
Build ID: b3b330e544df8fb802403fe133e8f8095966ac12
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 4 Olivier Hallot 2024-09-16 20:05:24 UTC
(In reply to Rafael Lima from comment #3)

> 
> What icon set are you using?
> 

Colibre (SVG + Dark)

Toolbars: Extra large
Notebook bar: Large 
Sidebar: Large


Confirmed that the issue occurs with Colibre SVG (dark and light). 

Does not occurs with other SVG icon sets (Breeze, Elementary, Karasa Jaga)
Comment 5 Olivier Hallot 2024-09-16 20:09:47 UTC
Colibre SVG (dark/light) icons also render bad in Windows.

LibreOffice 24.8.1.2
Comment 6 Rafael Lima 2024-09-16 22:20:02 UTC
Confirmed with

Version: 24.8.2.0.0+ (X86_64) / LibreOffice Community
Build ID: b3b330e544df8fb802403fe133e8f8095966ac12
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

Wrong icon being used with Colibre SVG Dark. This results in a gigantic lock icon. Clicking the checkbox will use a smaller icon, but a black one (instead of the expected white icon on a dark theme).
Comment 7 Rafael Lima 2024-09-16 22:23:11 UTC
This issue also affects gtk3... the icon gets even bigger.

Removing the kf5 tag.
Comment 9 Commit Notification 2024-09-17 11:49:14 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b72068ba689af7f292eca707df5765fda8109fb5

tdf#162990 Colibre (and Dark) SVG: fix unlocked icon and add locked icon

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Buovjaga 2024-09-17 11:49:48 UTC
Verified by Rafael, thanks.
Comment 11 Commit Notification 2024-09-17 14:47:54 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/3ed2932d1e6db06103cca2e13ca70c5465febee6

tdf#162990 Colibre (and Dark) SVG: fix unlocked icon and add locked icon

It will be available in 24.8.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.