Bug 163006 - Layout loop control fires many times when loading a specific DOCX
Summary: Layout loop control fires many times when loading a specific DOCX
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:25.2.0 target:24.8.2
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-17 11:31 UTC by Mike Kaganski
Modified: 2024-09-23 13:40 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
A sample generating "LoopControl_1 in SwLayAction::InternalAction" in console (3.44 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2024-09-17 11:31 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2024-09-17 11:31:52 UTC
Created attachment 196505 [details]
A sample generating "LoopControl_1 in SwLayAction::InternalAction" in console

Open the attachment in a debug build. See the messages in console.
Multiple (~250) identical lines appear there, before the file opens eventually:

> warn:legacy.osl:17476:21544:sw/source/core/layout/layact.cxx:597: LoopControl_1 in SwLayAction::InternalAction

Each means 20 loops of layout attempts, so it is more than 5000 layout iterations in total.
Comment 1 Mike Kaganski 2024-09-17 11:45:39 UTC
https://gerrit.libreoffice.org/c/core/+/173559
Comment 2 Commit Notification 2024-09-17 19:58:06 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2f6504dd84fc37bbf8d7798d4a60fc592aa7a67e

tdf#163006: fix keep-together rows height calculation

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2024-09-23 13:40:24 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/8044fbab5fd3382843369e7c692e27ba615e1518

tdf#163006: fix keep-together rows height calculation

It will be available in 24.8.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.