Bug 163284 - FORMATTING: Diagonal/criss-cross borders for tables do not work in Draw/Impress
Summary: FORMATTING: Diagonal/criss-cross borders for tables do not work in Draw/Impress
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.3.3.2 release
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:25.2.0 target:24.8.3
Keywords:
Depends on:
Blocks: ImpressDraw-Toolbars ImpressDraw-Tables
  Show dependency treegraph
 
Reported: 2024-10-04 06:31 UTC by Kira Tubo
Modified: 2024-11-04 09:29 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kira Tubo 2024-10-04 06:31:07 UTC
Description:
The diagonal/criss-cross borders are available buttons for tables in Draw/Impress. Activating them does not draw the appropriate table borders. 

Steps to Reproduce:
1. Open Draw/Impress
2. Insert Table
3. On bottom toolbar, click on Borders button 
4. Click on Diagonal Down Border, Diagonal Up Border, Criss-Cross Border
5. Note results

Actual Results:
Nothing happens. No borders are drawn. 

Expected Results:
Either 1) the appropriate diagonal/criss-cross border is drawn OR 2) remove the buttons if these features are not going to be supported for Draw/Impress


Reproducible: Always


User Profile Reset: No

Additional Info:
Reproduced in: 

Version: 7.3.3.2 (x64) / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 6; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0679a5cee16ae96c0d11e7d4fc1e59fb0f9cc591
CPU threads: 6; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Not reproduced in (i.e. diagonal/criss-cross border buttons not available):

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 6; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 1 m_a_riosv 2024-10-04 11:00:11 UTC
Reproducible
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3370e122d7f9edf40895f90706047ceb8ee7229d
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

Should be the same as in Writer not allowing that.
Comment 2 Julien Nabet 2024-10-04 16:32:30 UTC
After tdf#146407, Writer won't display diagonal borders options, should we do the same for Impress/Draw?
If yes, perhaps we should rename m_bIsWriter into m_bShowDiagonalBorders and implement it accordingly?
Comment 3 Heiko Tietze 2024-10-17 10:46:47 UTC
(In reply to Julien Nabet from comment #2)
> After tdf#146407, Writer won't display diagonal borders options, should we
> do the same for Impress/Draw?
Sure, makes no sense to offer a property that wont apply. But rather we fix it and provide criss-cross borders in all modules.
Comment 4 Julien Nabet 2024-10-19 16:45:11 UTC
I gave a try with https://gerrit.libreoffice.org/c/core/+/175199

I tested what I had indicated but it finally didn't work so tried another way.

I agree it would be better to implement criss-cross borders in all modules but it's above my expertise.
Comment 5 Commit Notification 2024-10-22 15:14:58 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b2d35dfe19aec40d34f1a2cca0a83ef4cef23a7d

tdf#163284: Diagonal/criss-cross borders for tables is only implemented in Calc

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-10-25 14:05:23 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/af0798f4c04d402a2c7be3623e08b129764d9f25

tdf#163284: Diagonal/criss-cross borders for tables is only implemented in Calc

It will be available in 24.8.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Gabor Kelemen (allotropia) 2024-11-04 08:47:47 UTC
Tested in:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 665dce4442e48b133b9fe1a2eb792ed3ef81d90c
CPU threads: 14; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: default

The Table toolbar button no longer shows the diagonal icons, but the Table properties dialogs Border tab still does.