Bug 163667 - Saving a particular spreadsheet takes a very long time
Summary: Saving a particular spreadsheet takes a very long time
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.2.0.0 beta1+
Hardware: All All
: high normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0 target:24.8.4
Keywords: bibisected, bisected, filter:xlsx, regression
Depends on:
Blocks:
 
Reported: 2024-10-29 08:54 UTC by Timur
Modified: 2024-11-11 21:37 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
a profile of this issue (342.44 KB, image/svg+xml)
2024-10-29 10:47 UTC, Caolán McNamara
Details
test XLSX (30.37 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2024-11-04 18:22 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2024-10-29 08:54:37 UTC
Saving XLSX NOK.
Regression from 24.2 in bug 158440.
https://gerrit.libreoffice.org/c/core/+/159905
https://git.libreoffice.org/core/+/8b2369236dea7d6863c2df3d4ce5e356c9c8010c

commit 8b2369236dea7d6863c2df3d4ce5e356c9c8010c	[log]
author	Henry Castro <hcastro@collabora.com>	Thu Nov 23 11:49:15 2023
sc: fix back color filter entries
Comment 1 Caolán McNamara 2024-10-29 10:47:57 UTC
Created attachment 197288 [details]
a profile of this issue
Comment 2 Commit Notification 2024-10-30 07:52:16 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/77fc900cfaf9d8b8fa0edb48ef38e0bdf7f2091d

fix bug in XclExpXF::Init (tdf#163667 related)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2024-11-01 20:17:04 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2c280a6de9cba0ba0cc9f1ae2ee120c0011eca09

tdf#163667 speed up spreadsheet with lots of cond formatting

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Timur 2024-11-04 18:22:05 UTC
Created attachment 197403 [details]
test XLSX
Comment 5 Commit Notification 2024-11-05 19:26:14 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/be11f27453f83d6a624fee898a50af471069edbd

tdf#163667 speed up spreadsheet with lots of cond formatting (II)

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-11-05 19:28:18 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/0fd14d68e728a7317215c6b0884725e319a9862d

fix bug in XclExpXF::Init (tdf#163667 related)

It will be available in 24.8.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Jazevedo 2024-11-11 21:31:54 UTC
 
> It will be available in 25.2.0.

> Affected users are encouraged to test the fix and report feedback.

Tested on: 25.2.0.0.alpha0+

Saving worked. Took only a couple of seconds to save. 

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 46009c851764857e67202875cea7d4566bf6abeb
CPU threads: 20; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 8 Jazevedo 2024-11-11 21:37:11 UTC
> https://git.libreoffice.org/core/commit/
> 0fd14d68e728a7317215c6b0884725e319a9862d
 
> fix bug in XclExpXF::Init (tdf#163667 related)
> 
> It will be available in 24.8.4.


> Affected users are encouraged to test the fix and report feedback.

Tested on 24.8.4.0.0+

The file used, took more than 20 seconds to save. With Libreoffice not responding during that time.

Version: 24.8.4.0.0+ (X86_64) / LibreOffice Community
Build ID: c9bc2df1f1f68c7cfca84c0b205b34d82528a28e
CPU threads: 20; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded