Bug 163726 - Sifr's resize / rotate handles don't contrast enough with document background and/or application background
Summary: Sifr's resize / rotate handles don't contrast enough with document background...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.8.1.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: High-Contrast Icon-Themes-Code-UpdateUI Icon-Theme-Sifr
  Show dependency treegraph
 
Reported: 2024-11-01 23:18 UTC by Stéphane Guillou (stragu)
Modified: 2024-11-05 09:29 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
light document background, dark mode Sifr (60.70 KB, image/png)
2024-11-01 23:18 UTC, Stéphane Guillou (stragu)
Details
Sifr light after switching GNOME High Contrast on while LO open (46.88 KB, image/png)
2024-11-01 23:20 UTC, Stéphane Guillou (stragu)
Details
Sample document (12.70 KB, application/vnd.oasis.opendocument.graphics)
2024-11-05 09:24 UTC, Michael Weghorn
Details
Screenshot with Sifr dark on light doc background (53.35 KB, image/png)
2024-11-05 09:27 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2024-11-01 23:18:30 UTC
Created attachment 197345 [details]
light document background, dark mode Sifr

The Sifr icon theme's resize (square) and rotate (circle) handles do not contrast enough with light backgrounds (document background, application background, or both).

This is already an issue in general use of the icon theme, but is even more of a problem when the icon theme is automatically used in High Contrast mode, and the handles do not update until LO is restarted - at least in my configuration (Ubuntu 24.04 with GNOME 46 on Wayland - see second screenshot). This is likely related to icon refresh issues listed in meta bug 124941.

Expected results: icons should contrast suitably with all backgrounds (combining dark and light colours), or should dynamically adapt to what is behind.

Tested in own build with recent master sources:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0746914ed0778ff82329162508985fc6f7655aba
CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Same issue in 24.8.1.
Comment 1 Stéphane Guillou (stragu) 2024-11-01 23:20:55 UTC
Created attachment 197346 [details]
Sifr light after switching GNOME High Contrast on while LO open

The dark mode Sifr handles do not refresh automatically when switching to High Contrast mode with LO open. This results in barely visible light handles on light backgrounds, until a restart of LO.
Comment 2 Michael Weghorn 2024-11-05 09:24:44 UTC
Created attachment 197411 [details]
Sample document
Comment 3 Michael Weghorn 2024-11-05 09:27:33 UTC
Created attachment 197412 [details]
Screenshot with Sifr dark on light doc background
Comment 4 Michael Weghorn 2024-11-05 09:28:48 UTC
I can reproduce like this:

1) set a dark system theme (I used "Breeze Dark" global theme on KDE Plasma)
2) open the attached sample doc attachment 197411 [details] in LO, using the gtk3 VCL plugin
3) click on the  line

Attachment 197412 [details] shows the result I get. The handle on the light document background (pointed to by the red arrow) has very low contrast to the document background.
Comment 5 Michael Weghorn 2024-11-05 09:29:18 UTC
(In reply to Michael Weghorn from comment #4)
> I can reproduce like this:
> 
> [...]

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 063c834f9db89c74431783e30b4dd3a2ed0c06fb
CPU threads: 32; OS: Linux 6.11; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: CL threaded