Bug 166684 - Loading XLSX file with complex formula and comments slow
Summary: Loading XLSX file with complex formula and comments slow
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
25.8.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Noel Grandin
URL:
Whiteboard: target:25.8.0 inReleaseNotes:25.8
Keywords: perf
Depends on:
Blocks: File-Opening
  Show dependency treegraph
 
Reported: 2025-05-22 08:16 UTC by Noel Grandin
Modified: 2025-06-09 12:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (6.51 MB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2025-05-22 08:16 UTC, Noel Grandin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Noel Grandin 2025-05-22 08:16:27 UTC
Description:

Large file with lots of formula, conditional formatting and comments loading in 500 seconds or more.

This is the TDF side of Collabora bug T58790.

Actual Results:
x

Expected Results:
x


Reproducible: Always


User Profile Reset: No

Additional Info:
x
Comment 1 Noel Grandin 2025-05-22 08:16:58 UTC
Created attachment 200906 [details]
sample file
Comment 2 Commit Notification 2025-05-23 07:46:39 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/79322a7025bb6fd61928204f90230560b09b4ba9

tdf#166684 strip out some unnecessary UNO work

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2025-05-23 13:02:26 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/56da031f73f544d712b369f732f1ded1d3926fc2

tdf#166684 strip out some unnecessary UNO work (2)

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2025-05-24 12:10:45 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/916e00d3a9a91680c6ce757ca2f37b81df732784

tdf#166684 suppress scanning of rotation attributes

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2025-05-24 18:31:27 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/04986d105a2b81a2b549d722541f5aa3a04f3937

tdf#166684 avoid O(n^2) loop in ScDocument::AddValidationEntry

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2025-05-24 20:01:40 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c8742f36fa2bdc9d23042378f5b587ccda8b54dd

tdf#166684 reduce cost of CellAttributeHelper::registerAndCheck

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Buovjaga 2025-05-25 09:01:30 UTC
The improvements so far are outstanding. With 25.2 I get

real    12m21,872s
user    12m20,400s
sys     0m1,112s

With master including the previous commits I get

real    0m8,802s
user    0m9,717s
sys     0m0,567s
Comment 8 Commit Notification 2025-05-25 10:32:06 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b3df12b9781daa19eff2b1e30526e65ca2aaa193

tdf#166684 avoid O(n^2) loop when importing comments

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2025-05-26 08:54:32 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3d9f900c9e5466a66b9beeaa0d2b82c22063628a

tdf#166684 make ScCondFormatItem hashable

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.