Bug 168377 - crash: use sidebar manage changes to reject all when UNDO is involved
Summary: crash: use sidebar manage changes to reject all when UNDO is involved
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.1.2 release
Hardware: All All
: high major
Assignee: Justin L
URL:
Whiteboard: target:26.2.0 target:25.8.3 target:25...
Keywords: bisected, regression
Depends on:
Blocks: Track-Changes Crash
  Show dependency treegraph
 
Reported: 2025-09-12 15:53 UTC by Justin L
Modified: 2025-10-08 13:14 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2025-09-12 15:53:48 UTC
I can consistently crash LO by
1.) open Untitled 2.odt (attachment 178403 [details] from bug 147548)
2.) go to the end of the document and hold down KEY_BACKSPACE until everything is deleted.
3.) press Ctrl-Z once to undo
4.) use the sidebar's "manage changes" to reject all - CRASH

This started in 7.4.1 with 7.5's backported
commit 7d730cd580e957ab06b0c7f020ac37dd0c337aa2
Author: Michael Stahl on Wed Aug 17 10:43:04 2022 +0200
    tdf#147466 sw_redlinehide: avoid crashing by delete un-deleting
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138411

Note that Edit - Track Changes - Reject All (or manage...) doesn't crash. The sidebar came in 7.4, so the backport to 7.3.6 wasn't negatively affected AFAICS.

Not blaming since this is likely a side effect - and only seen using the sidebar.
Comment 1 BogdanB 2025-09-12 18:44:42 UTC
Confirm with
Version: 25.8.1.1 (X86_64)
Build ID: 54047653041915e595ad4e45cccea684809c77b5
CPU threads: 16; OS: Linux 6.14; UI render: default; VCL: gtk3
Locale: ro-RO (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 2 Commit Notification 2025-09-18 14:47:24 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c920581dc81e553a07d0cd27f5d218df39811b6d

tdf#168377 sw: avoid crash in redlndlg - index out of range

It will be available in 26.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2025-09-18 20:59:16 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-25-8":

https://git.libreoffice.org/core/commit/d24e8a20907bf3e861dad93456d0dea891c3b320

tdf#168377 sw: avoid crash in redlndlg - index out of range

It will be available in 25.8.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2025-09-29 14:56:38 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-25-8-2":

https://git.libreoffice.org/core/commit/a77849455d13fb21079aa58b6c5a7b1d5c73d781

tdf#168377 sw: avoid crash in redlndlg - index out of range

It will be available in 25.8.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2025-10-08 13:14:17 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/5b9a6092ed0f0d96ce39e64e493089d9a65f257c

tdf#168377 sw: avoid crash in redlndlg - index out of range

It will be available in 25.2.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.