Created attachment 204449 [details] Screenshot of the issue When in Light mode on Windows I change to Dark mode, there is a notification dialog "restart needed", where the buttons already have dark background, but not light text yet, making them hard to read. 1. In Options - Appearance choose Dark mode and "Enable application theming" 2. Press OK -> Restart Needed dialog is shown, but the buttons are unreadable When switching from Dark theme to Light, the buttons are readable. Version: 26.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 620(Build:0) CPU threads: 24; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-US Calc: threaded
Created attachment 204452 [details] opposite low contrast going from Dark -> Automatic, when os/DE in Light color scheme Notice the fg text on bg fill, so readable but at very low contrast. Also, since you are being prompted--means you had the Tools -> Options -> Appearance 'Enable application theming' checked enabled. And it actually does manifest going between Dark -> Automatic (return from override of os/DE Light color scheme ) with light fg on light bg fill. Clip attached. The Automatic - Dark - Light Was the low contrast some of the luminosity/contrast work that Sahil did as the Appearance themes were reworked?
@Sahil, what do you think?
(In reply to V Stuart Foote from comment #1) > The Automatic - Dark - Light > Better finish that thought... The Automatic - Light - Dark appearance modes are supposed to more closely follow the os/DE color scheme. fg/bg of some button controls or list boxes don't immediately switch to follow a Light/Dark override of Automatic. While checking 'Enable application theming' and applying a fully authored "Appearance theme" is intended to override/reset what is passed in from the os/DE. But again as with the see also bug 167157 and bug 167159 some controls do not pick up the color set in a theme. Not clear how much of that is our win vcl backend lack of native controls, or if it is global affecting other os/DE.
Does not happen for me, neither Win nor Linux/Qt, but I can imagine situations where this happens. And the UI changes partly for me too. Perhaps we could delay the new theme to after the restart (or better apply properly without any restart).
With 26.8+ I do not see Restart dialog anymore (which I saw before and is screenshotted here) but Apply makes buttons Apply-OK-Cancel wrong color, whoch seems the same issue.
To reproduce Restart dialog in 26.8+ I used Enable Application Theming.
So this happens when the user directly presses the `OK` button. If they press `Apply` first and then `OK`, this does not happen. I am looking into it, it should not happen in the first case (when the user presses `OK`), looking into it...
Sahil Gautam committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d0038ca58e7dfd4a7a9ad8f4b6f889231dbd9f95 tdf#169839 Call ColorConfig_Impl::SetupTheme before showing the restartdlg It will be available in 26.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sahil Gautam committed a patch related to this issue. It has been pushed to "libreoffice-26-2": https://git.libreoffice.org/core/commit/c0b5b3d2100edf8e9d27036c3d8d831e2333a753 tdf#169839 Call ColorConfig_Impl::SetupTheme before showing the restartdlg It will be available in 26.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.