Bug 33483 - Not possible to undone more than 999 steps
Summary: Not possible to undone more than 999 steps
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
(earliest affected)
3.3.0 release
Hardware: x86 (IA32) Linux (All)
: medium trivial
Assignee: Andreas Becker
Depends on:
Reported: 2011-01-25 09:15 UTC by Karlos
Modified: 2012-05-08 13:34 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

make the undo steps box to behave correctly (682 bytes, patch)
2011-04-23 13:36 UTC, Andreas Becker

Note You need to log in before you can comment on or make changes to this bug.
Description Karlos 2011-01-25 09:15:30 UTC
In Writer, Calc and Impress (didn't check any other), in Tools - Options - Memory it is possible to set the "Undone" counter to more than 1000 steps. But, if 1000+ steps are set and the program restarted, the counter goes back to 100 (default option).

If the counter is set to 999, after a restart it remains at this number.

The problem seems that the counter in the Tools - Options - Memory section has no limit (you can write any number), but that there is a real limit in the number of steps the Undone counter accepts.
Comment 1 Andreas Becker 2011-04-23 13:36:34 UTC
Created attachment 46001 [details]
make the undo steps box to behave correctly

The attached patch solves the problem and makes 1000 undo steps possible.

The reason for the problem was, that MaxTextLength=4 was set in the GUI description. That overrided the Maximum=1000 setting in the GUI.

As far as I grepped and grok'd, this NumericField was the only one with MaxTextLength defined.

Although removing MaxTextLength like in the patch solved the problem, a clean way would be to
* declare MaxTextLength as invalid for NumericField, an
  error should be raised during compile time if that is possible or
* ignore MaxTextLength for NumericField.

By the way, the whole vcl code urgently needs revision.
Comment 2 Michael Meeks 2012-05-08 13:34:48 UTC
similar patch made it to master - thanks for that ! :-)