Bug Hunting Session
Bug 34828 - Navigator item "Draw objects" in Calc does not show Draw objects without name (Writer fixed in the mean time..)
Summary: Navigator item "Draw objects" in Calc does not show Draw objects without name...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 124989 (view as bug list)
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2011-02-28 04:46 UTC by sasha.libreoffice
Modified: 2019-04-30 13:18 UTC (History)
16 users (show)

See Also:
Crash report or crash signature:


Attachments
explanation and screenshots of navigator problem (35.35 KB, application/vnd.oasis.opendocument.text)
2011-02-28 04:46 UTC, sasha.libreoffice
Details
How it would look like with all shapes appearing (190.82 KB, image/png)
2016-03-15 11:10 UTC, Samuel Mehrbrodt (CIB)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sasha.libreoffice 2011-02-28 04:46:28 UTC
Created attachment 43923 [details]
explanation and screenshots of navigator problem

In navigator never appears "Drawing objects".
Used LibreOffice 3.3.1.2 Mandriva 64 bit Kde 4.4 and windows xp 32 bit
In attachment explanation and screenshots of navigator problem.
Comment 1 GerardF 2011-02-28 06:10:06 UTC
(In reply to comment #0)
> In navigator never appears "Drawing objects".

If you want to see "Drawing objects" in the navigator, you may name these objects. Right-clic > Name.

Don't remember, but i think it is the same in OpenOffice.
Comment 2 Cédric Bosdonnat 2011-02-28 07:15:06 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > In navigator never appears "Drawing objects".
> 
> If you want to see "Drawing objects" in the navigator, you may name these
> objects. Right-clic > Name.
> 
> Don't remember, but i think it is the same in OpenOffice.

Indeed you need to name the draw objects to make them appear here. This would be an enhancement to have them shown here.
Comment 3 sasha.libreoffice 2011-02-28 07:44:22 UTC
Thanks about Name. I do not know about this.
Comment 4 Björn Michaelsen 2011-12-23 11:45:28 UTC Comment hidden (obsolete)
Comment 5 sasha.libreoffice 2012-01-02 02:41:26 UTC
reproduced in LibO 3.5.0 beta 1
Comment 6 Roman Eisele 2012-05-04 07:40:56 UTC
This is a general UI issue, right? Therefore changed 'Component' field accordingly.
Comment 7 Rainer Bielefeld Retired 2013-03-28 09:49:59 UTC
In Draw Navigator shows all draw objects, even any simple line, if you enable 'Show Shapes -> All Shapes'. This problem does not exist there.

Bu I can confirm the problem for Writer and Calc, there always exists an item "Draw Objects", where I even can select a 'Drag Mode', but that's useful for nothing if there are no shapes listed. 

So I consider this one a bug.

That never worked in LibO or OOo, see "AOOo#17444 - unnamed objects in navigator"

May be we simply need in heading of Navigator the icon 'Show Shapes -> All Shapes' as we have it in Draw / Impress?

@Thorsten:
Can you please rate the easyhack proposal? I had to learn that many issues related to inherited Draw code are not as simple as they might look.
Comment 8 Jean-Francois Nifenecker 2014-02-22 17:27:44 UTC
This problem seems to come from the fact that drawing objects added in Writer are not named by default. Naming them as "Drawing 1", "Drawing 2", etc. by default could probably help.
Comment 9 Joel Madero 2014-02-27 23:22:27 UTC
In order to limit the confusion between ProposedEasyHack and EasyHack and to make queries much easier we are changing ProposedEasyHack to NeedsDevEval.

Thank you and apologies for the noise
Comment 10 Harald Koester 2015-10-08 12:49:05 UTC
(In reply to Jean-Francois Nifenecker from comment #8)
> This problem seems to come from the fact that drawing objects added in
> Writer are not named by default. Naming them as "Drawing 1", "Drawing 2",
> etc. by default could probably help.

I would appreciate a default naming of drawing objects. All other objects (tables, comments,..) are named by default, only drawing objects are not named. Also particularly if an object is covered by another object this is only way to select the covered object without modifying the covering object. Furthermore I propose that the default name also indicates the kind of an object. E.g. Rectangle1, Rectangle2, Circle1, Square1, ...
Comment 11 Robinson Tryon (qubit) 2015-12-14 06:12:39 UTC Comment hidden (obsolete)
Comment 12 Samuel Mehrbrodt (CIB) 2016-03-15 11:10:47 UTC
Created attachment 123588 [details]
How it would look like with all shapes appearing
Comment 13 Samuel Mehrbrodt (CIB) 2016-03-15 11:40:27 UTC
Have a patch for this here: https://gerrit.libreoffice.org/#/c/23265/ which enables show unnamed shapes.

However, I am not sure this is the right approach. Maybe we should rather go with default names for shapes as we do with images?
Comment 14 Regina Henschel 2016-03-15 17:29:04 UTC
I use a Version: 5.2.0.0.alpha0+
Build ID: 129d199d27f6961ea0c850686f76c83e2fc1953d
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-03-11_06:16:01
Locale: de-DE (de_DE)

If I insert a Draw object into a Writer document, it is named automatically and therefore it is listed in the Navigator. So for Writer nothing is to do.
Comment 15 Samuel Mehrbrodt (CIB) 2016-03-15 17:35:26 UTC
(In reply to Regina Henschel from comment #14)
> If I insert a Draw object into a Writer document, it is named automatically
> and therefore it is listed in the Navigator. So for Writer nothing is to do.

Oh this seems to have changed in 5.2 - thanks for testing. So I guess this can be closed then :)
Comment 16 Regina Henschel 2016-03-15 17:43:27 UTC
It is only solved in Writer, in Calc they are not named automatically.

And for Calc the discussion remains whether to use the solution of Writer to name them automatically or use the solution of Draw/Impress to have a special mode (with icon in Navigator) to show or hide unnamed objects.
Comment 17 Harald Koester 2016-08-30 10:00:34 UTC
Current situation:

Beginning with version 5.1.0 drawing objects are named automatically with Shape1, Shape2, ... in Writer. A differentiation between kinds of objects (line, rectangle, Circle, ...) is not performed like proposed in comment 10 and comment 12.

In Calc neither in version 5.1.0 nor in version 5.2.0 an automatic naming of drawing objects is performed. Hence this bug is not completely fixed. Set back to NEW.
Comment 18 Thomas Lendo 2017-09-16 01:38:56 UTC Comment hidden (obsolete)
Comment 19 QA Administrators 2018-09-17 02:46:33 UTC Comment hidden (obsolete)
Comment 20 Thomas Lendo 2018-09-17 05:32:13 UTC
Still reproducible.

Version: 6.2.0.0.alpha0+ (x64)
Build ID: 18c5089df091bddeb8c2dc339776671964389040
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-09-12_23:24:12
Locale: de-AT (de_AT); Calc: CL
Comment 21 Cor Nouws 2018-09-18 11:27:27 UTC
(In reply to Thomas Lendo from comment #20)
> Still reproducible.


When opening the first attached file (attachment 43923 [details]) I do not see them in the Navigator.
But
 - starting a new Writer document;
 - using Drawing toolbar;
 - clicking a shape and drawing it in the document
  >> F5 shows "shape 1", "shape 2" etc

Version: 6.2.0.0.alpha0+
Build ID: 8c20d5d4ad6f3e8c672337e3ba67be45a1ccb7c2
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-09-14_02:29:28
Locale: nl-NL (nl_NL.UTF-8); Calc: threaded

So..
Comment 22 Thomas Lendo 2018-09-20 11:10:42 UTC
(In reply to Cor Nouws from comment #21)
> When opening the first attached file (attachment 43923 [details]) I do not
> see them in the Navigator.
> But
>  - starting a new Writer document;
>  - using Drawing toolbar;
>  - clicking a shape and drawing it in the document
>   >> F5 shows "shape 1", "shape 2" etc
Right, but not in Calc.
Comment 23 Cor Nouws 2018-09-23 07:56:23 UTC
(In reply to Thomas Lendo from comment #22)

> Right, but not in Calc.

Ah.. better make a separate issue for that?
Comment 24 Thomas Lendo 2018-09-23 17:48:35 UTC
(In reply to Cor Nouws from comment #23)
> Ah.. better make a separate issue for that?
I'd go with the existing bug. All necessary information is here for future commits.
Comment 25 Aron Budea 2019-04-24 06:46:20 UTC
(In reply to Harald Koester from comment #17)
> Beginning with version 5.1.0 drawing objects are named automatically with
> Shape1, Shape2, ... in Writer. A differentiation between kinds of objects
> (line, rectangle, Circle, ...) is not performed like proposed in comment 10
> and comment 12.
For reference, this was done by the following commit:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3647626309ef89bf90d8b6a6539d41d8deb6b482
author		Caolán McNamara <caolanm@redhat.com>	2015-09-17 13:55:28 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2015-09-17 14:12:08 +0100

Give drawing objects unique names by default
Comment 26 Heiko Tietze 2019-04-30 13:18:44 UTC
*** Bug 124989 has been marked as a duplicate of this bug. ***