Bug 36013 - Writer crashes when on documents that contains >=2^16 style changes
Summary: Writer crashes when on documents that contains >=2^16 style changes
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.3.1 release
Hardware: Other All
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 19:20 UTC by Andriy Rysin
Modified: 2011-12-29 14:37 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Rysin 2011-04-05 19:20:10 UTC
I open the document and when I close it I consistently get a Writer crash. The
sample document that causes the crash can be found here http://dict.linux.org.ua/other/sheludko.odt

The document has several styles which alternate frequently.

On (even) bigger documents I get crash when changing style properties or even when opening the document.

This is the same problem as https://openoffice.org/bugzilla/show_bug.cgi?id=84159 which was fixed in ooo dev-3.4. The problem though it was fixed quite inefficiently: the large document (2k-3k pages) I am working with took several minutes to open and almost 10 min to save on modern laptop in ooo <= 3.3. But in ooo dev-3.4 it took ~40min to open and it took almost 3 hours to save. Even closing the document in ooo dev-3.4 takes at least half an hour. So even though the crash is fixed this solution makes the office unusable for such documents.

It would be nice if this crash could be fixed but in more efficient way.
Comment 1 tester8 2011-04-06 05:00:48 UTC
Reproduced with AndrewMacro.odt (crash on close).
Not reproduced with sheludko.odt and charstylescrash.odt (no crash after editing, saving and closing).

My config is
LibreOffice 3.3.2 RC2 (1:3.3.0-1lucid1) - Ubuntu 10.04 x86 Linux 2.6.32-30-generic Russian UI

Andriy Rysin, what is your OS and LO versions?
Comment 2 Andriy Rysin 2011-04-06 05:21:24 UTC
The version I use now is 3.3.1. I've seen this crash on Windows and Linux both 32 and 64 bit. I can't tell for sure but I think the crash is more often on 64 bit.

Right now with 3.3.1 on Linux 64 (OpenSuse 11.4) sheludko.odt crashes LO on closing for me.
Comment 3 Jan Holesovsky 2011-04-14 04:41:46 UTC
Can you please try with LibreOffice 3.4 beta?  Thank you!
Comment 4 Andriy Rysin 2011-04-14 20:38:51 UTC
Thanks! It looks much better with LibreOffice 3.4 beta - I could not reproduce the crash when closing documents with neither of sheludko.odt, AndrewMacro.odt, charstylescrash.odt.

Two caveats though:
1) I've seen a Segmentation Fault couple of times when I was opening/closing those documents (one at a time) and then after I close the document I do Exit and I see:
$ /opt/libreoffice/program/swriter
Segmentation fault
but it does not impact the save so it may not be as critical

Note: another pretty reliable source of the crash was to change style properties, highlight tons of sparse text with Find All and do huge copy/pastes - I didn't try those yet. If I have time to try them I'll post the results here.

2) for large documents (I have one with ~3000 pages also with frequent style changes) and it takes ~6-7 min to load this document (while earlier versions of LO and OOo would do that in ~1-2min if they don't crash :)), saving takes at least 20-30 min - I didn't wait till the end. And just closing this big document takes ~8min (it's a Core 2 Duo 2.1GHz)
Interestingly the progress bar seems to be slowing down as it progresses, so seems the more document has been processes the slower the process gets.
Though I guess I'll have to open a separate bug for that (unless one already exists)
Comment 5 LeMoyne Castle 2011-06-13 13:48:36 UTC
Removed NEEDINFO tags - reporter says fixed in 3.4 beta 
Left open as likely still a flaw in 3.3
Comment 6 Andriy Rysin 2011-06-20 20:20:46 UTC
I've filed a separate bug for performance regression in https://bugs.freedesktop.org/show_bug.cgi?id=38513
Comment 7 Björn Michaelsen 2011-12-23 12:05:11 UTC
[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
Comment 8 tester8 2011-12-29 14:29:21 UTC
LOdev 3.5.0beta2 
4ca392c-760cc4d-f39cf3d-1b2857e-60db978
Ubuntu 10.04.3 x86
Linux 2.6.32-37-generic Russian UI

NOT reproduced. Long closing but no crash.