Bug 36230 - [EasyHack] Remove dead code aGotoCallButton and RID_IMGBTN_GOTOCALL
Summary: [EasyHack] Remove dead code aGotoCallButton and RID_IMGBTN_GOTOCALL
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
(earliest affected)
Hardware: Other All
: medium normal
Assignee: Noel Power
Keywords: difficultyBeginner, easyHack, skillCpp
Depends on:
Reported: 2011-04-14 03:58 UTC by Christian Dywan
Modified: 2015-12-15 12:16 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Remove unused aGotoCallButton and RID_IMGBTN_GOTOCALL (3.32 KB, patch)
2011-04-14 04:18 UTC, Christian Dywan

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dywan 2011-04-14 03:58:25 UTC
The AGotoCallButton is never shown and basically unused code, and accordingly RID_IMGBTN_GOTOCALL. So it should be removed.

See http://wiki.documentfoundation.org/Development/Easy_Hacks#Remove_obsolete_product_pieces
Comment 1 Christian Dywan 2011-04-14 04:18:24 UTC
Created attachment 45602 [details]
Remove unused aGotoCallButton and RID_IMGBTN_GOTOCALL
Comment 2 Noel Power 2011-04-15 02:52:43 UTC
ok, taking it
Comment 3 Noel Power 2011-04-18 05:17:21 UTC
Thanks for the patch, it's pushed ( I also removed the id completely from the source (  svx/inc/svx/svxids.hrc )

commits are here

Comment 4 Noel Power 2011-04-18 05:17:37 UTC
mark as fixed
Comment 5 Björn Michaelsen 2011-07-28 10:00:21 UTC
=== Remove specific dead code ===

'''Background:''' We have lots of dead code around, one example is: basicide/source/basicide/baside2b.cxx - where we have code related to RID_IMGBTN_GOTOCALL that creates an aGotoCallButton that has no icon and is always hidden. We should remove both the code, the .src and .hrc defines.

'''Skills:''' simple C++

'''Finished the part of removing aGotoCallButton''': Christian Dywan, christian.dywan@lanedo.com, 2011-04-21 [https://bugs.freedesktop.org/show_bug.cgi?id=36230 fdo#36230]
Comment 6 Robinson Tryon (qubit) 2015-12-15 12:16:52 UTC
Migrating Whiteboard tags to Keywords: (EasyHack DifficultyBeginner SkillCpp)