Bug 38742 - Pushpins/Favourites in recent menu and start center
Summary: Pushpins/Favourites in recent menu and start center
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Andreas Heinisch
URL:
Whiteboard: target:7.6.0 target:24.2.0 target:7.6...
Keywords:
: 60743 91815 96509 96968 104736 109013 123982 128680 130899 (view as bug list)
Depends on:
Blocks: Recent-Document-List Start-Center 155700 155701 155746 155698 155699
  Show dependency treegraph
 
Reported: 2011-06-28 03:23 UTC by Andrey Poltavets
Modified: 2023-09-15 09:57 UTC (History)
20 users (show)

See Also:
Crash report or crash signature:


Attachments
Word 2019 new files not pined (27.29 KB, image/png)
2023-05-16 11:44 UTC, Formaint'Info
Details
Word 2019 recents files not pined (40.42 KB, image/png)
2023-05-16 11:51 UTC, Formaint'Info
Details
Icon position proposal (23.16 KB, image/png)
2023-05-17 20:37 UTC, Andreas Heinisch
Details
Softmaker pin documents workflow (237.20 KB, image/gif)
2023-06-09 00:09 UTC, Rizal Muttaqin
Details
I would like to see the separator between pinned and unpinned documents like this. (101.65 KB, image/png)
2023-06-09 00:26 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Poltavets 2011-06-28 03:23:16 UTC
I think, it is nice to see in future pushpins (or somethings else) in recent documents´ pop-up menu. I mean something like pushpins of MS Office 2007.

Many people are working with tens of documents, so I think this feature will be pleasant for them.
Comment 1 Björn Michaelsen 2011-12-23 12:23:51 UTC Comment hidden (obsolete)
Comment 2 Florian Reisinger 2012-08-14 13:59:45 UTC Comment hidden (obsolete)
Comment 3 Florian Reisinger 2012-08-14 14:00:54 UTC Comment hidden (obsolete)
Comment 4 Florian Reisinger 2012-08-14 14:05:38 UTC Comment hidden (obsolete)
Comment 5 Florian Reisinger 2012-08-14 14:07:39 UTC Comment hidden (obsolete)
Comment 6 sasha.libreoffice 2012-09-20 14:27:34 UTC
Indeed, in msOffice presents thumbnails in list of recent files. But what they do?
IMHO it would be more simply to increase maximum of recent files in list. For example to 20 or 30.
Reopening because it is RFE
Comment 7 Joel Madero 2013-01-29 19:15:54 UTC
This is a valid request for sure.

Marking:
New (confirmed)
Enhancement
Medium (useful enough for quite a few users, leaving as medium)


Thanks for reporting!
Comment 8 bfoman (inactive) 2013-03-10 00:15:04 UTC
This could be implemented as part of Recently Used Files list enhancement in bug 61174, point 3.
Comment 9 V Stuart Foote 2016-01-08 13:27:42 UTC
*** Bug 91815 has been marked as a duplicate of this bug. ***
Comment 10 Yan Pas 2016-03-14 23:03:56 UTC
*** Bug 96509 has been marked as a duplicate of this bug. ***
Comment 11 V Stuart Foote 2016-12-17 22:48:12 UTC
*** Bug 104736 has been marked as a duplicate of this bug. ***
Comment 12 V Stuart Foote 2017-07-08 12:31:10 UTC
*** Bug 109013 has been marked as a duplicate of this bug. ***
Comment 13 Gabor Kelemen (allotropia) 2019-04-08 15:22:19 UTC
*** Bug 123982 has been marked as a duplicate of this bug. ***
Comment 14 V Stuart Foote 2019-11-09 14:40:21 UTC
*** Bug 128680 has been marked as a duplicate of this bug. ***
Comment 15 V Stuart Foote 2020-02-25 06:25:41 UTC
*** Bug 130899 has been marked as a duplicate of this bug. ***
Comment 16 Heiko Tietze 2020-12-11 10:59:54 UTC
*** Bug 96968 has been marked as a duplicate of this bug. ***
Comment 17 Larry 2020-12-11 18:58:21 UTC
The "pushpins" enhancement would be very helpful to me, whereas merely expanding the "recent files" list would not be as beneficial.
I have some files that I need to access and update on a monthly basis.
In the meantime, I may have opened more than 40-50 other files that I only needed to work with one time.

Thus, the recent files is nice, but being able to quickly open the files that I have to use on a regular (but not daily or weekly) basis is more important to me.
Comment 18 Buovjaga 2021-09-26 19:14:59 UTC
*** Bug 60743 has been marked as a duplicate of this bug. ***
Comment 19 Andreas Heinisch 2023-05-04 07:56:51 UTC
After the change in https://wiki.documentfoundation.org/ReleaseNotes/7.6#GUI where do we expect favorited documents? Are they on top of the module specific list separated with a line or are they included in that list?

In addition, where do users expect these push pins? Before the file image, after the image before the file name or at the end of the filename itself? Maybe there is another variant where such a push pin may be placed.
Comment 20 Heiko Tietze 2023-05-04 08:08:12 UTC
(In reply to Andreas Heinisch from comment #19)
> ...where do we expect favorited documents?

On top of the MRU list, at the beginning of the start center list. Both separated from the other items. I don't care too much whether these are sorted by module or last usage. Either way is good.

Tagging the file would be done in the start center, by the way. I imagine an outlined pushpin symbol that becomes filled when clicked. Or any other icon theme specific solution: clicking the favorite icon toggles the state.
Comment 21 sdc.blanco 2023-05-04 08:37:22 UTC
(In reply to Heiko Tietze from comment #20)
> Tagging the file would be done in the start center, by the way. 
If it were also possible to add/remove a document another way (e.g., with a toggle, which could be added/customized to a menu/toolbar), then this would improve workflow considerably (for those who keep LO open with multiple files, and sleep/hibernate their machine, rather than restarting LO everyday, which makes it hard to get to the start center).
Comment 22 Heiko Tietze 2023-05-04 08:46:52 UTC
(In reply to sdc.blanco from comment #21)
> (In reply to Heiko Tietze from comment #20)
> > Tagging the file would be done in the start center, by the way. 
> If it were also possible to add/remove a document another way...

I respectfully disagree. Ruling out the menu only a dedicated UNO command is an option and I don't see a toolbar button / menu entry "Make the current document a favorite" a common workflow. On the other hand, it makes sense to upvalue the start center.
Comment 23 sdc.blanco 2023-05-04 08:52:37 UTC
(In reply to Heiko Tietze from comment #22)
> Ruling out the menu only a dedicated UNO command is an option 
+1

> don't see a toolbar button / menu entry "Make the current
> document a favorite" a common workflow. 
A "pushpin" (toggle) icon (that could be customized, e.g., to the beginning of the "standard" toolbar) would do the trick, for uncommon users.
Comment 24 Formaint'Info 2023-05-16 11:44:20 UTC
Created attachment 187326 [details]
Word 2019 new files not pined

In Word 2019, in the new file pane you can pin a file. So it would be very useful to pin a file into the Star Center.
On the top right angle of the thumbnail, you've got the cross to delete the file. You could have the pin on the top right angle.
Comment 25 Formaint'Info 2023-05-16 11:51:17 UTC
Created attachment 187328 [details]
Word 2019 recents files not pined

And in the recents files menu the pushpin could be at end of the line in front on the name of the file.
Comment 26 Andreas Heinisch 2023-05-16 12:43:51 UTC
Is there anything like a push pin in the LibreOffice icon set, or do we have create something?
Comment 27 Heiko Tietze 2023-05-16 14:01:12 UTC
(In reply to Andreas Heinisch from comment #26)
> Is there anything like a push pin in the LibreOffice icon set, or do we have
> create something?

Rizal think there is one for help pages but likely not open/closed. And I'm sure he is happy to create some nice new icons.
Comment 28 Andreas Heinisch 2023-05-17 20:37:22 UTC
Created attachment 187357 [details]
Icon position proposal

Item position proposal. Which one do you prefer? Or do we have another possibility to set the icon? I have used just a placeholder to demonstrate the position.
Comment 29 Andreas Heinisch 2023-05-20 10:54:44 UTC
I finished the implementation of the feature. What is still missing is the icons to pin/unpin a document. Heiko maybe you could ask Rizal to create one? 🤓 Thank you very much!
Comment 30 Heiko Tietze 2023-05-22 05:52:28 UTC
(In reply to Andreas Heinisch from comment #29)
> Heiko maybe you could ask Rizal to create one?

Just submit the patch (can't wait to review the workflow *g*) and file a new ticket with the icon request.
Comment 31 Commit Notification 2023-06-06 05:09:12 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/436f3f8eb5b45620842351a1f29ba49571043515

tdf#38742 - Start Center: introduce push pins to favorite documents

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 32 Andreas Heinisch 2023-06-06 05:14:14 UTC
Working patch. The following items are missing:

- Clear recent documents should not clear pinned items
- Recently used documents should show pinned items, maybe with a smaller icon
- Hover effects for pinned/unpinned items (with a plus/minus)
- New items have to be created to visually fit with all the themes

Happy to hear your thoughts and opinions about the current implementation :)
Comment 33 Heiko Tietze 2023-06-06 07:30:13 UTC
(In reply to Andreas Heinisch from comment #32)
> Working patch.
Many thanks for your work! Let's set this one to fixed and work on the follow-up tickets.

Bug 155698 - Clear recent documents should not clear pinned items
Bug 155699 - MRU should show pinned items first
Bug 155700 - Improve feedback for pushpin actions
Bug 155701 - Context menu for items in the start center

> - New items have to be created to visually fit with all the themes
Don't get this (and maybe missed the point for the other aspects). Please file a new ticket. Discussion whether or not and how to should be done there.
Comment 34 Commit Notification 2023-06-08 13:06:24 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1b368909b09cd62494239faaea09bb500dc9f19d

tdf#38742 - Start Center: odb files messes up pinned documents

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 35 Rizal Muttaqin 2023-06-09 00:09:53 UTC
Created attachment 187796 [details]
Softmaker pin documents workflow

This is how FreeOffice or SoftMaker (FreeOffice TextMaker 2021 (rev F1064.0513) 64bit) pin document workflow in action. I see this is easy to understand.
Comment 36 Rizal Muttaqin 2023-06-09 00:26:04 UTC
Created attachment 187797 [details]
I would like to see the separator between pinned and unpinned documents like this.

Also, the label should has capability to change the name based on plural (pinned documents/unpinned documents) and singular (pinned document/unpinned document) items.
Comment 37 Rizal Muttaqin 2023-06-09 00:38:58 UTC
I don't know whether this request should be another ticket or not:

The file that resides on a remote location which can be detached anytime and temporary directory like /tmp CAN NOT be pinned
Comment 38 Andreas Heinisch 2023-06-09 05:30:42 UTC
Comment 34 and comment 35 belong to bug 155699. I don't know if softmakers' workflow is a 100% clear. At first I thought that clicking on the X icon will remove the document from the list and not from thw pinned documents. Maybe we can do some hover effect on the pinned icon with a PLUS sign in the icon if it will be added and a MINUS sign otherwise.
Comment 39 Andreas Heinisch 2023-06-09 05:32:46 UTC
The separator is a good idea. I will add it in an additional patch.
Comment 40 Andreas Heinisch 2023-06-09 05:33:32 UTC
Comment 37 should be a separate ticket. Thank you.
Comment 41 Heiko Tietze 2023-06-09 06:20:51 UTC
Rizal, please file new tickets. I disagree with the interaction on menu items and to block pinning of remote documents but could agree with those living in temp space and appreciate the separator idea.

I used this ticket as Depends On to not introduce a new META ticket. But maybe that would be better.
Comment 42 Rizal Muttaqin 2023-06-09 06:22:10 UTC
(In reply to Andreas Heinisch from comment #38)
> Comment 34 and comment 35 belong to bug 155699. I don't know if softmakers'
> workflow is a 100% clear. At first I thought that clicking on the X icon
> will remove the document from the list and not from thw pinned documents.
> Maybe we can do some hover effect on the pinned icon with a PLUS sign in the
> icon if it will be added and a MINUS sign otherwise.

OK thanks for pointing proper bug report

X icon remove the file from the list: wherever the file are e.g. clicking X icon on pinned item will remove the file from pinned list, and clicking the X icon on unpinned item will remove the file from unpinned list.

I suggest hover effect in tdf#155700 ( I say it mouse over state)
Comment 43 Rizal Muttaqin 2023-06-09 06:30:25 UTC
(In reply to Heiko Tietze from comment #41)
> Rizal, please file new tickets. 

Here the ticket: tdf#155746
Comment 44 Commit Notification 2023-06-12 13:57:37 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/2b332cace587fadd645de375c8327e58e7ca10cb

tdf#38742 - Start Center: odb files messes up pinned documents

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 45 Commit Notification 2023-06-19 05:48:25 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/760c7a806ced3861086d5fdfbb7b4b1461948c27

tdf#38742 - Start Center: move last opened documents to the top

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 46 Commit Notification 2023-06-20 07:11:59 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/0e54294046c33cd2bbda6318ee61242dbfd8dcf6

tdf#38742 - Start Center: move last opened documents to the top

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 47 Mike Kaganski 2023-09-11 05:35:56 UTC
No mention in the release notes?
Comment 48 Andreas Heinisch 2023-09-12 06:51:56 UTC
I thought that the placeholder for the icons are not very appealing, so I didn't add them to the release notes. Maybe there is a person who is capable to generate better icons.
Comment 49 Mike Kaganski 2023-09-12 06:59:53 UTC
(In reply to Andreas Heinisch from comment #48)

Please add them as they are.
1. This is an important change of functionality, a new feature. No matter what the icons look like - it is not about the specific look of a pin anyway, because that would differ from there to theme.
2. Adding them to release notes would increase their visibility, and promote possible improvement of the pin look.
Comment 50 Andreas Heinisch 2023-09-15 09:57:19 UTC
https://wiki.documentfoundation.org/ReleaseNotes/7.6#GUI